WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#38808 closed defect (bug) (fixed)

Merge similar translation strings in WordPress 4.7

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:

Description

Some strings can be merged to reduce the total amount of strings.

Attachments (24)

welcome.png (32.1 KB) - added by ramiy 7 months ago.
stick-posts.png (26.0 KB) - added by ramiy 7 months ago.
assign-term.png (39.0 KB) - added by ramiy 7 months ago.
user-added.png (24.4 KB) - added by ramiy 7 months ago.
38808-welcome.patch (754 bytes) - added by ramiy 7 months ago.
38808-sticky.patch (633 bytes) - added by ramiy 7 months ago.
38808-assign-terms.patch (1.8 KB) - added by ramiy 7 months ago.
recource-url.png (43.3 KB) - added by ramiy 7 months ago.
updating.png (15.7 KB) - added by ramiy 7 months ago.
search-results.png (27.8 KB) - added by ramiy 7 months ago.
delete-resource.png (58.2 KB) - added by ramiy 7 months ago.
no-results.png (103.6 KB) - added by ramiy 7 months ago.
author-id.png (16.4 KB) - added by ramiy 7 months ago.
38808-invalid.patch (2.5 KB) - added by ramiy 7 months ago.
allow-comments.png (23.6 KB) - added by ramiy 7 months ago.
invalid-parameter.png (17.8 KB) - added by ramiy 7 months ago.
38808-search-results.patch (643 bytes) - added by ramiy 7 months ago.
38808-delete-resource.patch (761 bytes) - added by ramiy 7 months ago.
38808-no-results.patch (734 bytes) - added by ramiy 7 months ago.
38808-updating.patch (742 bytes) - added by ramiy 7 months ago.
38808-allow-comments.patch (588 bytes) - added by ramiy 7 months ago.
38808-delete-post.patch (787 bytes) - added by ramiy 7 months ago.
edit-errors.png (182.9 KB) - added by ramiy 7 months ago.
38808.combined.patch (10.8 KB) - added by SergeyBiryukov 7 months ago.

Download all attachments as: .zip

Change History (29)

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

@ramiy
7 months ago

#2 @pedromendonca
7 months ago

This is a great work being done here!
Congratulations @ramiy :)

@ramiy
7 months ago

#3 @ramiy
7 months ago

  • Keywords has-patch added

#4 @SergeyBiryukov
7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.7

@ramiy, thank you for the patches! Here's my review:

38808.combined.patch is my take on the changes.

Last edited 7 months ago by SergeyBiryukov (previous) (diff)

#5 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39278:

Text Changes: Merge some duplicate strings with the same meaning in error messages, adjust some other strings for consistency and accuracy.

Props ramiy, SergeyBiryukov.
Fixes #38808.

Note: See TracTickets for help on using tickets.