Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 10 years ago

Closed 9 years ago

Last modified 5 years ago

#38815 closed defect (bug) (fixed)

Race conditions in Tests_Formatting_Date

Reported by:	ocean90	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.9
Component:	Build/Test Tools	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Same as #38381 but for Tests_Formatting_Date.

Example: Tests_Formatting_Date::test_get_gmt_from_date_string_date() in https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/176355621#L295

Attachments (1)

38815.patch (1017 bytes ) - added by keesiemeijer 10 years ago.: Add a delta for comparing timestamps

Download all attachments as: .zip

Change History (11)

@keesiemeijer
10 years ago

Attachment 38815.patch added

Add a delta for comparing timestamps

#1 @keesiemeijer
10 years ago

Keywords has-patch added; needs-patch removed

in 38815.patch I've also removed strtotime( 'now' ) from the timestamp parameter in gmdate() as it defaults to the current local time if a timestamp is not given.

Last edited 10 years ago by keesiemeijer (previous) (diff)

#2 @SergeyBiryukov
9 years ago

#42263 was marked as a duplicate.

#3 @SergeyBiryukov
9 years ago

Milestone Future Release → 4.9

#4 @SergeyBiryukov
9 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Props keesiemeijer.
Fixes #38815.

This ticket was mentioned in Slack in #core-datetime by sergey. View the logs.

7 years ago

#6 @SergeyBiryukov
5 years ago

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.8 branch.
See #38815.

#7 @SergeyBiryukov
5 years ago

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.7 branch.
See #38815.

#8 @SergeyBiryukov
5 years ago

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.6 branch.
See #38815.

#9 @SergeyBiryukov
5 years ago

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.5 branch.
See #38815.

#10 @SergeyBiryukov
5 years ago

Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.

Follow-up to [35284].

Props keesiemeijer.
Merges [41920] to the 4.4 branch.
See #38815.

Note: See TracTickets for help on using tickets.

Download in other formats: