Closing Link Options in TinyMCE shouldn't return you to editor (and remove the link)

[rhyswynne]

Here's my workflow:-

1. Highlight some text.
2. Click the Link Icon.
3. Put a URL in the text box.
4. Click "Link Options".
5. Close the window.

I feel like right now it probably should instead return to the box in step 3, rather than close completely.

[lukecavanagh]

Current default state

[helen]

I think I understand what's being described, but a screencast of that workflow would be helpful here.

[azaozz]

Yes, the way it works now is a "two stage dialog". First is the simple dialog, if you want to add more options, you open the "advanced" dialog.

If I understand correctly you want to return to the "simple" dialog after opening the "advanced" one but deciding not to use it (step 5, "Close the (modal) window"). In the advanced dialog (the modal) you can do all the things that are available in the simple dialog (inline).

Think that the current behavior is better. Closing a dialog generally means that "you're done with it" so opening the simple dialog again may be annoying in that context.

[rhyswynne]

Hi All,

Sorry for the delay! Been busy.

I've recorded said video. It is available at this URL:-

​https://cloudup.com/cVbNUBFiuuj

My workflow is demonstrated as to why it could cause confusion - in that I can add a link, click advanced options, and then close. It loses the link. I may want to keep the link?

Minor irritation I know :)

[azaozz]

Minor irritation I know :)

Yeah, still good to clear it out though :)

Closing the "advanced link" modal is equal to clicking "Cancel". This is the standard behaviour when clicking on any "close" button. That's why the link isn't inserted. Don't think we should change that behaviour, would be more confusing, also perhaps will have accessibility implications.