Add filter for post statuses in _update_post_term_count()

[GunGeekATX]

_update_post_term_count() is hard-coded to only use the 'publish' status when updating the post count for a term. The lack of a filter here does not allow the term count to include other post statuses (or custom post statuses) in situations where the user would like the term count to reflect the other statuses.

Example of using proposed patch to allow 'future' status to be included in Category term count.

add_filter( 'update_post_term_count_statuses', function( $post_statuses, $taxonomy ) {

	// Allow future statuses to be counted for Category post count.
	if ( 'category' === $taxonomy->name ) {
		$post_statuses[] = 'future';
	}

	return $post_statuses;
}, 10, 2 );

[GunGeekATX]

Proposed patch with filter

[davecpage]

Related: #39372

[adamsilverstein]

In 38843.diff​: Updated patch and added test coverage for new filter.

Trac ticket:

[nwjames]

Modified the SQL to change the second occurence of "= 'publish

[nwjames]

Sorry my comment with the modified diff was a little cryptic.

The SQL statement is rather long and contained 2 occurrences of "= 'publish'" (one for posts and the other for attachments).

The previous fix addressed only the first one.

[hellofromTonya]

Adds a new filter. Noting needs inclusion into the misc dev note.

[audrasjb]

patch refreshed against trunk

[audrasjb]

@hellofromTonya @SergeyBiryukov patch and unit tests refreshed as per today's bug scrub.

[hellofromTonya]

Works: tested before and after applying patch 38843.2.diff

[hellofromTonya]

Attached gif shows the changes work. Here's the hooked callback I used in a must-use file:

<?php
add_filter(
        'update_post_term_count_statuses',
        function ( $statuses, $taxonomy ) {
                if ( 'category' === $taxonomy->name ) {
                        $statuses[] = 'draft';
                        $statuses[] = 'future';
                        $statuses[] = 'pending';
                }

                return $statuses;
        },
        10,
        2
);

Marking this ticket ready as a commit candidate.

[peterwilsoncc]

#51517 was marked as a duplicate.

[hellofromTonya]

Refreshed to fix failing test and phpcs errors.

[TimothyBlynJacobs]

@param int $taxonomy Current taxonomy object. should be a WP_Taxonomy right? It'd be nice to get this in a PR.

[hellofromTonya]

Good catch @TimothyBlynJacobs. Adding it. Will submit patch in a moment.

[hellofromTonya]

Changes @param from int to WP_Taxonomy. Props Timothy.

[antpb]

In 50169:

Taxonomy: Add filter for post statuses when updating term count.

This adds a filter that allows $post_statuses to be modified in term count.

Props GunGeekATX, adamsilverstein, davecpage, nwjames, hellofromTonya, audrasjb, peterwilsoncc, TimothyBlynJacobs.
Fixes #38843.

Closed with changeset https://core.trac.wordpress.org/changeset/50169

[SergeyBiryukov]

In 50231:

Docs: Use typed array notation in the update_post_term_count_statuses filter DocBlock.

Follow-up to [50169].

See #38843.

[audrasjb]

Dev note published: ​https://make.wordpress.org/core/2021/02/23/miscellaneous-developer-focused-changes-in-wordpress-5-7/