WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#38862 closed defect (bug) (fixed)

Remove method names from translation string

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: I18N Keywords:
Focuses: Cc:

Description

Replace "Use WP_Image_Editor::rotate" and "Use WP_Image_Editor::flip" with "Use %s". Method names should not be translatable, they should be hardcoded. To prevent PTE's accidentally misspell the method name and mislead users/developers.

Attachments (2)

use.png (22.7 KB) - added by ramiy 7 months ago.
38862.patch (1.0 KB) - added by ramiy 7 months ago.

Download all attachments as: .zip

Change History (6)

@ramiy
7 months ago

@ramiy
7 months ago

#1 @SergeyBiryukov
7 months ago

  • Milestone changed from Awaiting Review to 4.7

#2 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 39314:

I18N: Remove unnecessary __() calls in _rotate_image_resource() and _flip_image_resource().

Use _deprecated_function()'s native strings.

Props ramiy.
Fixes #38862.

#3 @SergeyBiryukov
7 months ago

In 39315:

I18N: Add translator comments for strings in _deprecated_*() functions.

See #38862.

#4 @SergeyBiryukov
7 months ago

In 39316:

I18N: Use 'WordPress hook name' instead of 'PHP hook name' in translator comments added in [39315].

See #38862.

Note: See TracTickets for help on using tickets.