Twenty Seventeen: Edit button label is displayed vertical in some situations in Japanese

[tg29359]

In Japanese, ​edit button label is displayed vertically in some situations ("edit" in Japanese is "編集"). ​In other situations, edit button label is displayed horizontally in Japanese. That's somewhat strange.

The vertical situation I guess:

• set theme to Twenty Seventeen.
• set site language and user language to Japanese.
• export Japanese translation files from ​GlotPress, and rename these files to twentyseventeen-ja.po/twentyseventeen-ja.mo, and upload these files to the directory something like "wp-content/languages/themes/" on the site.
• assign some widgets to sidebar.
• view single post blog page with the screen size wide enough to display sidebar.

[tg29359]

add to the vertical situations: log on the site as editable user, of course.

[davidakennedy]

@tg29359 Thanks for the report! Can you upload a screenshot here? That way, it's easier to know what we're looking for when trying to reproduce the problem.

[tg29359]

vertical screenshot

[tg29359]

horizontal screenshot

[tg29359]

Replying to davidakennedy:

@tg29359 Thanks for the report! Can you upload a screenshot here? That way, it's easier to know what we're looking for when trying to reproduce the problem.

@davidakennedy
Yes, I can. I attached the screenshots to this ticket.

[afercia]

Worth noting this happens for any language where text wraps character-by-character, since they don't delimit words with spaces. Happens with Chinese and Korean too, or even if "Edit" gets translated with two separate words (see last screenshot where I've just inserted a space in the middle of "Edit").

Ideographic languages can be written in different directions. If standardising to horizontal writing direction is acceptable, then this can probably be fixed easily with white-space: nowrap.

[tg29359]

Standardising to horizontal writing direction is acceptable in this situation. Even though Japanese words are often written vertically, contents of a web-site are usually written horizontally even in Japan.

[helen]

nowrap sounds good to me, milestoning for 4.7, hopefully is a straightforward patch.

[davidakennedy]

In 39341:

Twenty Seventeen: Ensure edit button label displays properly in other languages

This bug occurred in any language where text wraps character-by-character, since those languages don't delimit words with spaces. In Japanese, Chinese and Korean, etc., it was possible for the label to be displayed vertically.

Props tg29359, afercia, odysseygate.

Fixes #38876.