WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

#38882 closed task (blessed) (duplicate)

Add translator comments to every string that contains a placeholder

Reported by: johnbillion Owned by: johnbillion
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

Strings that contain placeholders — such as %s, %d, and %1$s — should include accompanying translator comments. This provides context to translators and allows for more accurate translations.

The meaning of even seemingly simple strings containing placeholders may not be clear to translators who are not intimately familiar with WordPress, unless a translator comment is provided.

Change History (10)

#1 @johnbillion
3 years ago

  • Owner set to johnbillion
  • Status changed from new to assigned

#3 @johnbillion
3 years ago

In 39323:

I18n: Begin introducing translator comments for strings which include placeholders but no accompanying translator comment.

Adds context to one string used in two different contexts for the new user and new site signup email notification.

More to come.

See #38882

#4 @johnbillion
3 years ago

In 39324:

Remove an erroneous @TODO introduced in [39323].

See #38882

#5 @johnbillion
3 years ago

In 39326:

I18n: Introduce more translator comments for strings that contain placeholders but don't have an accompanying translator comment.

See #38882

#6 @ocean90
3 years ago

@johnbillion Comments which are for the placeholders %s or %d shouldn't use "1", it should be the name of the placeholder.

#7 @desrosj
7 months ago

  • Keywords needs-patch reporter-feedback added

@johnbillion Are you able to wrap this up or summarize what is left? Also, it appears that @ocean90's concern still needs to be addressed.

#8 @johnbillion
6 months ago

  • Keywords reporter-feedback removed
  • Milestone changed from Future Release to 5.3

#10 @johnbillion
5 months ago

  • Milestone 5.3 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Superseded by #44360.

Note: See TracTickets for help on using tickets.