WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#38901 closed defect (bug) (fixed)

Twenty Seventeen CSS coding standards review

Reported by: netweb Owned by: joemcgill
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

A review of the Twenty Seventeen themes CSS per WordPress' CSS Coding Standards

p.s. It was so much easier to perform these reviews per pull request when development was on GitHub ;)

Attachments (2)

38901.diff (2.5 KB) - added by netweb 9 months ago.
38901.2.diff (2.7 KB) - added by joemcgill 9 months ago.

Download all attachments as: .zip

Change History (5)

@netweb
9 months ago

@joemcgill
9 months ago

#1 @joemcgill
9 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to joemcgill
  • Status changed from new to accepted

#2 @joemcgill
9 months ago

Hi @netweb,

Looks like the Microsoft filter is buggy when shorthand color codes are used. See: http://codepen.io/joemcgill/pen/mOmyMW in IE8.

https://cldup.com/_X9sJjg0zp.thumb.png

38901.2.diff reverts your patch to the previous behavior here and fixes a couple of typos I missed in the inline docs for the custom header video button styles.

#3 @joemcgill
9 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39340:

Twenty Seventeen: CSS coding standards fixes.

This makes a few adjustments to CSS to bring them inline with WordPress
CSS coding standards including:

  • Font weights should be defined using numeric values
  • Do not pad parentheses with spaces

This also fixes a couple of typos to inline comments.

Props netweb for initial patch.
Fixes #38901.

Note: See TracTickets for help on using tickets.