WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 4 months ago

#38913 new enhancement

Aggregation of contracted and not contracted verb forms (cannot, doesn't)?

Reported by: Presskopp Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 4.7
Component: Administration Keywords: good-first-bug has-patch needs-copy-review
Focuses: ui-copy Cc:

Description

I count

18x does not vs. 5x doesn't
28x cannot vs. 4x can not vs. 1x can't (+ 1x in 'administration')
lots of is not vs 1x isn't

Do we want to combine them?

Attachments (2)

38913.patch (27.9 KB) - added by aandrewdixon 2 years ago.
Patch changes "can not" and "can't" to "cannot", "doesn't" to "does not" and "isn't" to "is not".
38913.2.patch (79.1 KB) - added by aandrewdixon 2 years ago.
Trying again as my first attempt somehow missed the whole wp-includes directory when I was searching, plus I found some other words like haven't, couldn't, etc... that needed changing as well.

Download all attachments as: .zip

Change History (17)

#1 @ramiy
5 years ago

Related: #39176

#2 @desrosj
3 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

#3 @Presskopp
3 years ago

@desrosj What is the decision? What forms of expression would we use preferrably?

#4 @socalchristina
2 years ago

Hi @Presskopp. I see in
ticket:39176#comment:4 that the preferred form of expression is to replace doesn't contraction with does not. Is that the consensus on contractions @desrosj? I'm happy to work on this but I don't see a reference to the particular file.

#5 @aandrewdixon
2 years ago

Personally, I think the non-contracted verb form is much clearer, particularly for people were their first language is not English but they are using an English install for whatever reason.

@aandrewdixon
2 years ago

Patch changes "can not" and "can't" to "cannot", "doesn't" to "does not" and "isn't" to "is not".

@aandrewdixon
2 years ago

Trying again as my first attempt somehow missed the whole wp-includes directory when I was searching, plus I found some other words like haven't, couldn't, etc... that needed changing as well.

#6 @Mista-Flo
2 years ago

  • Keywords has-patch added; needs-patch removed

#7 @Presskopp
20 months ago

Do not you ..

should be avoided, if you ask me

#8 @garrett-eclipse
20 months ago

  • Component changed from Text Changes to Administration
  • Focuses ui-copy added

This ticket was mentioned in Slack in #core by francina. View the logs.


4 months ago

#10 follow-up: @francina
4 months ago

The ticket was mentioned during the new contributors chat on May 26th. The contracted verbs mentioned by the original reporter are probably not the only ones.
I suggest we make a list of all the possible contractions we should be looking for in the source code and evaluate which ones have to be "searched and replaced" and which ones should stay as contracted forms. As mentioned by @Presskopp "Do not you" is not a better option than "Don't you".

Top of my mind: potential contracted versions of "to be" (I'm, You're, Isn't it, etc...), to have (haven't), and can/could as mentioned by @aandrewdixon.

Does anyone else have any input on this? If you do, please leave your comment. Thanks!

#11 in reply to: ↑ 10 @SergeyBiryukov
4 months ago

Replying to francina:

I suggest we make a list of all the possible contractions we should be looking for in the source code and evaluate which ones have to be "searched and replaced" and which ones should stay as contracted forms.

When searching the core, make sure to also look for apostrophes encoded as numeric entities, e.g. doesn’t in addition to doesn't.

This ticket was mentioned in PR #1310 on WordPress/wordpress-develop by jeffpaul.


4 months ago

  • Keywords has-unit-tests added

This PR makes the following changes in expanding encoded contractions into its composite words:

  • doesn’t > does not
  • can’t > can not
  • won’t > will not
  • couldn’t > could not
  • don’t > do not
  • isn’t > is not
  • haven’t > have not
  • aren’t > are not
  • wasn’t > was not
  • we’re > we are
  • there’s > there is
  • I’m > I am
  • you’re > you are
  • you’d > you would

Note that this PR does NOT make changes of cannot to can not as I was not certain that was really helpful, but can amend the PR to make those changes if desired.

Similarly this PR does not change un-encoded contractions into its composite words (e.g., doesn't > 'does not') as many of those code comments and there are LOTS of them, but again is that is desired then I can amend the PR to include those changes as well.

Trac ticket: https://core.trac.wordpress.org/ticket/38913

#13 @JeffPaul
4 months ago

  • Keywords needs-copy-review added; has-unit-tests removed

#14 @JeffPaul
4 months ago

  • Milestone changed from Future Release to 5.9

This ticket was mentioned in Slack in #core by francina. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.