Make WordPress Core

Opened 7 years ago

Closed 2 years ago

Last modified 2 years ago

#38913 closed enhancement (fixed)

Aggregation of contracted and not contracted verb forms (cannot, doesn't)?

Reported by: presskopp's profile Presskopp Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version: 4.7
Component: Administration Keywords: has-patch has-unit-tests commit assigned-for-commit
Focuses: ui-copy Cc:

Description

I count

18x does not vs. 5x doesn't
28x cannot vs. 4x can not vs. 1x can't (+ 1x in 'administration')
lots of is not vs 1x isn't

Do we want to combine them?

Attachments (3)

38913.patch (27.9 KB) - added by aandrewdixon 5 years ago.
Patch changes "can not" and "can't" to "cannot", "doesn't" to "does not" and "isn't" to "is not".
38913.2.patch (79.1 KB) - added by aandrewdixon 5 years ago.
Trying again as my first attempt somehow missed the whole wp-includes directory when I was searching, plus I found some other words like haven't, couldn't, etc... that needed changing as well.
38913.diff (136.4 KB) - added by audrasjb 2 years ago.
patch refreshed against trunk

Download all attachments as: .zip

Change History (73)

#1 @ramiy
7 years ago

Related: #39176

#2 @desrosj
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

#3 @Presskopp
5 years ago

@desrosj What is the decision? What forms of expression would we use preferrably?

#4 @socalchristina
5 years ago

Hi @Presskopp. I see in
ticket:39176#comment:4 that the preferred form of expression is to replace doesn't contraction with does not. Is that the consensus on contractions @desrosj? I'm happy to work on this but I don't see a reference to the particular file.

#5 @aandrewdixon
5 years ago

Personally, I think the non-contracted verb form is much clearer, particularly for people were their first language is not English but they are using an English install for whatever reason.

@aandrewdixon
5 years ago

Patch changes "can not" and "can't" to "cannot", "doesn't" to "does not" and "isn't" to "is not".

@aandrewdixon
5 years ago

Trying again as my first attempt somehow missed the whole wp-includes directory when I was searching, plus I found some other words like haven't, couldn't, etc... that needed changing as well.

#6 @Mista-Flo
5 years ago

  • Keywords has-patch added; needs-patch removed

#7 @Presskopp
4 years ago

Do not you ..

should be avoided, if you ask me

#8 @garrett-eclipse
4 years ago

  • Component changed from Text Changes to Administration
  • Focuses ui-copy added

This ticket was mentioned in Slack in #core by francina. View the logs.


3 years ago

#10 follow-up: @francina
3 years ago

The ticket was mentioned during the new contributors chat on May 26th. The contracted verbs mentioned by the original reporter are probably not the only ones.
I suggest we make a list of all the possible contractions we should be looking for in the source code and evaluate which ones have to be "searched and replaced" and which ones should stay as contracted forms. As mentioned by @Presskopp "Do not you" is not a better option than "Don't you".

Top of my mind: potential contracted versions of "to be" (I'm, You're, Isn't it, etc...), to have (haven't), and can/could as mentioned by @aandrewdixon.

Does anyone else have any input on this? If you do, please leave your comment. Thanks!

#11 in reply to: ↑ 10 @SergeyBiryukov
3 years ago

Replying to francina:

I suggest we make a list of all the possible contractions we should be looking for in the source code and evaluate which ones have to be "searched and replaced" and which ones should stay as contracted forms.

When searching the core, make sure to also look for apostrophes encoded as numeric entities, e.g. doesn’t in addition to doesn't.

This ticket was mentioned in PR #1310 on WordPress/wordpress-develop by jeffpaul.


3 years ago
#12

  • Keywords has-unit-tests added

This PR makes the following changes in expanding encoded contractions into its composite words:

  • doesn’t > does not
  • can’t > can not
  • won’t > will not
  • couldn’t > could not
  • don’t > do not
  • isn’t > is not
  • haven’t > have not
  • aren’t > are not
  • wasn’t > was not
  • we’re > we are
  • there’s > there is
  • I’m > I am
  • you’re > you are
  • you’d > you would

Note that this PR does NOT make changes of cannot to can not as I was not certain that was really helpful, but can amend the PR to make those changes if desired.

Similarly this PR does not change un-encoded contractions into its composite words (e.g., doesn't > 'does not') as many of those code comments and there are LOTS of them, but again is that is desired then I can amend the PR to include those changes as well.

Trac ticket: https://core.trac.wordpress.org/ticket/38913

#13 @JeffPaul
3 years ago

  • Keywords needs-copy-review added; has-unit-tests removed

#14 @JeffPaul
3 years ago

  • Milestone changed from Future Release to 5.9

This ticket was mentioned in Slack in #core by francina. View the logs.


3 years ago

#16 @audrasjb
3 years ago

  • Keywords needs-refresh added

There are some conflicts in the proposed PR, so I'm adding needs-refresh workflow keyword.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

#18 @audrasjb
3 years ago

  • Keywords needs-copy-review removed

As per today's bug scrub:

This ticket is still a good candidate for 5.9, but we need a committer to finish the work, as the patch need to be committed soon after the refresh to avoid new conflicts (76 files are impacted by this patch).

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

@audrasjb
2 years ago

patch refreshed against trunk

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

#22 @hellofromTonya
2 years ago

  • Keywords needs-refresh removed
  • Owner set to hellofromTonya
  • Status changed from new to reviewing

This ticket was mentioned in PR #1840 on WordPress/wordpress-develop by audrasjb.


2 years ago
#23

  • Keywords has-unit-tests added

#24 @audrasjb
2 years ago

New PR available for review ☝️

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

hellofromtonya commented on PR #1840:


2 years ago
#26

@audrasjb the tests are failing as the strings changed. Mary Baum is reviewing the string changes to help me out. Once she's done and it's all okay, then the tests can be updated to match.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

#28 @audrasjb
2 years ago

PR refreshed @hellofromTonya. Tests are passing now.
I didn't include the proposed string changes are they are changing qunit strings (those are internal strings)

#29 @audrasjb
2 years ago

  • Keywords commit added

audrasjb commented on PR #1840:


2 years ago
#30

@audrasjb the tests are failing as the strings changed. Mary Baum is reviewing the string changes to help me out. Once she's done and it's all okay, then the tests can be updated to match.

PR refreshed :)

#31 @hellofromTonya
2 years ago

@audrasjb I'm not seeing the changes Mary Baum did, such as cannot instead of can not. Are those to be included in this commit?

#32 @audrasjb
2 years ago

@hellofromTonya maybe I'm misleading, but the diff file proposed by Mary was addressing strings used in unit tests so as I commented in the related thread, I'm not sure it's worth replacing these qunit sample sentences (they could be lorem ipsum text as well).
For reference: https://wordpress.slack.com/archives/C02RQBWTW/p1636425668068900

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

#34 @audrasjb
2 years ago

  • Keywords commit removed
  • Milestone changed from 5.9 to Future Release

Given the huge perimeter of this change (see this Trac thread https://wordpress.slack.com/archives/C02RQBWTW/p1636501241200000), the decision is to move this change to Future release, hopefully to early 6.0.

Removing commit for now.

#35 @SergeyBiryukov
2 years ago

Might be relevant for when the ticket gets picked up again:
Cannot, Can Not or Can’t—Which Should I Use? | Grammarly:

Don’t use can not when you mean cannot. The only time you’re likely to see can not written as separate words is when the word “can” happens to precede some other phrase that happens to start with “not”:

  • Example: We can not only break even, but also turn a profit.
  • Example: The company’s new product can not only reduce emissions, but also trap some of the existing greenhouse gasses.

Here is a quick summary:

  • Can’t is a contraction of cannot, and it’s best suited for informal writing.
  • In formal writing and where contractions are frowned upon, use cannot.
  • It is possible to write can not, but you generally find it only as part of some other construction, such as “not only . . . but also.”

#36 @hellofromTonya
2 years ago

  • Milestone changed from Future Release to 6.0
  • Owner hellofromTonya deleted

Hey 6.0 is now available. Moving it into 6.0. Removing myself as the reviewing as there's more work to be done before it's ready for commit.

#37 follow-up: @azouamauriac
2 years ago

this is still good-first-bug?

#38 in reply to: ↑ 37 @mirkolofio
2 years ago

Replying to azouamauriac:

this is still good-first-bug?

Nice question. I have another one for @audrasjb:

Given the huge perimeter of this change, how does a new contributor (like me) know when it's time to give it a boost?

#39 @audrasjb
2 years ago

  • Keywords needs-refresh added; good-first-bug removed
  • Owner set to audrasjb
  • Status changed from reviewing to accepted

Self assigning to refresh the PR, and removing good-first-bug tag.

audrasjb commented on PR #1840:


2 years ago
#40

@jeffpaul PR refreshed against trunk. It is available for final review :)

#41 @audrasjb
2 years ago

  • Keywords needs-refresh removed

@JeffPaul PR refreshed against trunk. It is available for final review :)

#42 @audrasjb
2 years ago

  • Keywords dev-feedback added

Pinging:

  • @Presskopp as you opened the ticket
  • @JeffPaul as you previously reviewed the patch
  • @SergeyBiryukov for a second core committer review

If everyone is fine with the current PR and since the current PR passes unit tests, I'm up to commit this now, so it could ship early in the release cycle :)

PR: https://github.com/WordPress/wordpress-develop/pull/1840

#43 @Presskopp
2 years ago

not sure of the can't => can not conversion, reading #35

#44 @JeffPaul
2 years ago

Interesting callout as I had missed Sergey's comment in #35, but yeah looks like maybe we should change can't to cannot?

#45 @JeffPaul
2 years ago

@audrasjb if you want, I can add another commit to your PR to make the change to cannot and let you handle review there?

#46 @audrasjb
2 years ago

@JeffPaul yes sure, it would be very appreciated, thank you :)

#47 @audrasjb
2 years ago

  • Keywords dev-feedback removed

Just for information, I plan to update the patch and commit it tomorrow :)

audrasjb commented on PR #1840:


2 years ago
#48

PR refreshed to replace "can not" with "cannot"

audrasjb commented on PR #1840:


2 years ago
#49

PR refreshed to replace "can not" with "cannot"

#50 @audrasjb
2 years ago

  • Keywords assigned-for-commit added

I refreshed the patch to replace the occurrences of "can not" with "cannot".

Marking as assigned-for-commit.

#51 @audrasjb
2 years ago

  • Keywords commit added

#52 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52978:

Administration: Replace contracted verb forms for better consistency.

This changeset replaces contracted verb forms like doesn't, can't, or isn't with non-contracted forms like does not, cannot, or is not, for better consistency across the WordPress administration. It also updates some corresponding unit tests strings.

Props Presskopp, socalchristina, aandrewdixon, francina, SergeyBiryukov, JeffPaul, audrasjb, hellofromTonya.
Fixes #38913.
See #39176.

#53 @audrasjb
2 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like this initial patch doesn’t (hmm… or even better: does not) handle a few occurrences. I'm preparing a follow-up patch.

#56 @SergeyBiryukov
2 years ago

Thanks for the commit! Trac does not show the diff for [52978] here due to a large number of changes, but I have reviewed it on GitHub and most of the changes look good to me :)

I think these two strings could use some further improvement, they seem a bit weird as is:

  • "If for some reason this does not work, do not worry. It does not work on all web hosts."
    • Suggested: "If for some reason this does not work, do not worry. It may not work on all web hosts."
  • "There are not any events scheduled near %1$s at the moment."
    • Suggested: "There are no events scheduled near %1$s at the moment."

#57 @audrasjb
2 years ago

In 52979:

Administration: Replace contracted verb forms for better consistency.

This changeset replaces contracted verb forms like doesn't, can't, or isn't with non-contracted forms like does not, cannot, or is not, for better consistency across the WordPress administration. It also updates some corresponding unit tests strings.

Follow-up to [52978].

See #38913.

#59 @audrasjb
2 years ago

  • Keywords assigned-for-commit removed

Ah thank you for the post-commit review @SergeyBiryukov.
The above PR addresses those issues :)

#60 @audrasjb
2 years ago

  • Keywords commit added

Committing the changes right now, and closing this ticket.

#61 @audrasjb
2 years ago

  • Keywords assigned-for-commit added

#62 @JeffPaul
2 years ago

Apologies, some personal issues have slowed me lately and didn't get around to that updated commit in the PR, thanks for picking that up @audrasjb!

#63 @audrasjb
2 years ago

No worries @JeffPaul! Thank you!

Unit tests are passing on PR2449.
Let's commit it and close the ticket.

#64 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52980:

Administration: Rephrase some sentences after [52978].

Follow-up to [52978], [52979].

Props SergeyBiryukov.
Fixes #38913.

#65 @audrasjb
2 years ago

In 52981:

Administration: Remove a duplicate sentence after [52980].

Follow-up to [52980], [52979], [52978].

Props SergeyBiryukov.
Fixes #38913.

audrasjb commented on PR #2449:


2 years ago
#66

Committed

audrasjb commented on PR #2447:


2 years ago
#67

Committed

audrasjb commented on PR #1840:


2 years ago
#68

Committed

audrasjb commented on PR #1310:


2 years ago
#69

Committed

#70 @audrasjb
2 years ago

In 53132:

Administration: Replace "can not" with "cannot" after [53131].

Follow-up to [53131], [52979].

See #46057, #38913

Note: See TracTickets for help on using tickets.