Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#38917 closed defect (bug) (fixed)

Paste As Text alert displays full-width

Reported by: mor10 Owned by: azaozz
Priority: normal Milestone: 4.7
Component: TinyMCE Version: 4.7
Severity: normal Keywords: has-patch commit reviewed
Cc: Focuses:

Description

4.7-beta4-39340

When clicking Paste as Text button for the first time, the alert that shows up has incomplete styling, spanning the full width of the screen rather than hovering over the content (see screenshot).

https://cldup.com/rj9Jx7Y6eX.png

Attachments (3)

mce-notice-1.png (38.1 KB ) - added by azaozz 10 years ago.
mce-notice-2.png (22.6 KB ) - added by azaozz 10 years ago.
38917.patch (400 bytes ) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in Slack in #core-editor by mor10. View the logs.


10 years ago

#2 @iseulde
10 years ago

  • Milestone Awaiting ReviewFuture Release

Looks like something goes wrong when TinyMCE calculates the position.

#3 @mor10
10 years ago

For reference, used to look like this:

https://cldup.com/dNTgsDy_7q.png

New alert should at least limit its footprint to something similar.

#4 @karmatosed
10 years ago

I can replicate this and can't see all the message:

https://cldup.com/KkaMllCq5d.png

It can get fixed by removing the left CSS position and adding a 50% width (probably best there's some device adjustments though):

https://cldup.com/ubj3Ree8RD.png

Last edited 10 years ago by karmatosed (previous) (diff)

#5 follow-up: @karmatosed
10 years ago

  • Keywords needs-patch added
  • Milestone Future Release4.7

Tentatively suggesting this needs fixing for 4.7 as it's a bug that impacts the experience a lot.

Last edited 10 years ago by karmatosed (previous) (diff)

#6 @azaozz
10 years ago

How about we center the notice by percentage, 10% on each side looks good?

@azaozz
10 years ago

@azaozz
10 years ago

@azaozz
10 years ago

#7 @azaozz
10 years ago

  • Keywords has-patch added; needs-patch removed

#8 in reply to: ↑ 5 ; follow-up: @helen
10 years ago

Replying to karmatosed:

Tentatively suggesting this needs fixing for 4.7 as it's a bug that impacts the experience a lot.

Just for future reference, slating something for 4.7 during RC should indicate that it's either a serious bug in a new feature or a fairly significant regression from 4.6. I think this falls under the latter, but should be clear about that.

#9 @iseulde
10 years ago

  • Keywords commit added

Looks good as a quick fix while we wait for an upstream fix.

#10 in reply to: ↑ 8 @azaozz
10 years ago

  • Keywords reviewed added

Replying to helen:

Yeah, it is a CSS related regression that happens specifically on that screen. Works properly in the TinyMCE demo. We didn't notice it earlier as this message is shown only for new users.

#11 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolutionfixed
  • Status newclosed

In 39367:

TinyMCE: fix the styling of notices generated by the editor UI.

Props: mor10, karmatosed, azaozz.
Fixes #38917.

#12 @azaozz
10 years ago

  • Resolution fixed
  • Status closedreopened

Reopen for 4.7.

#13 @azaozz
10 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 39501:

TinyMCE: fix the styling of notices generated by the editor UI.

Props: mor10, karmatosed, azaozz.
Fixes #38917 for 4.7.

Note: See TracTickets for help on using tickets.