WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#38917 closed defect (bug) (fixed)

Paste As Text alert displays full-width

Reported by: mor10 Owned by: azaozz
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: TinyMCE Keywords: has-patch commit reviewed
Focuses: Cc:

Description

4.7-beta4-39340

When clicking Paste as Text button for the first time, the alert that shows up has incomplete styling, spanning the full width of the screen rather than hovering over the content (see screenshot).

https://cldup.com/rj9Jx7Y6eX.png

Attachments (3)

mce-notice-1.png (38.1 KB) - added by azaozz 5 months ago.
mce-notice-2.png (22.6 KB) - added by azaozz 5 months ago.
38917.patch (400 bytes) - added by azaozz 5 months ago.

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in Slack in #core-editor by mor10. View the logs.


5 months ago

#2 @iseulde
5 months ago

  • Milestone changed from Awaiting Review to Future Release

Looks like something goes wrong when TinyMCE calculates the position.

#3 @mor10
5 months ago

For reference, used to look like this:

https://cldup.com/dNTgsDy_7q.png

New alert should at least limit its footprint to something similar.

#4 @karmatosed
5 months ago

I can replicate this and can't see all the message:

https://cldup.com/KkaMllCq5d.png

It can get fixed by removing the left CSS position and adding a 50% width (probably best there's some device adjustments though):

https://cldup.com/ubj3Ree8RD.png

Last edited 5 months ago by karmatosed (previous) (diff)

#5 follow-up: @karmatosed
5 months ago

  • Keywords needs-patch added
  • Milestone changed from Future Release to 4.7

Tentatively suggesting this needs fixing for 4.7 as it's a bug that impacts the experience a lot.

Last edited 5 months ago by karmatosed (previous) (diff)

#6 @azaozz
5 months ago

How about we center the notice by percentage, 10% on each side looks good?

@azaozz
5 months ago

@azaozz
5 months ago

@azaozz
5 months ago

#7 @azaozz
5 months ago

  • Keywords has-patch added; needs-patch removed

#8 in reply to: ↑ 5 ; follow-up: @helen
5 months ago

Replying to karmatosed:

Tentatively suggesting this needs fixing for 4.7 as it's a bug that impacts the experience a lot.

Just for future reference, slating something for 4.7 during RC should indicate that it's either a serious bug in a new feature or a fairly significant regression from 4.6. I think this falls under the latter, but should be clear about that.

#9 @iseulde
5 months ago

  • Keywords commit added

Looks good as a quick fix while we wait for an upstream fix.

#10 in reply to: ↑ 8 @azaozz
5 months ago

  • Keywords reviewed added

Replying to helen:

Yeah, it is a CSS related regression that happens specifically on that screen. Works properly in the TinyMCE demo. We didn't notice it earlier as this message is shown only for new users.

#11 @azaozz
5 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 39367:

TinyMCE: fix the styling of notices generated by the editor UI.

Props: mor10, karmatosed, azaozz.
Fixes #38917.

#12 @azaozz
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.7.

#13 @azaozz
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 39501:

TinyMCE: fix the styling of notices generated by the editor UI.

Props: mor10, karmatosed, azaozz.
Fixes #38917 for 4.7.

Note: See TracTickets for help on using tickets.