WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#38937 closed defect (bug) (fixed)

Twenty Seventeen: Specific fonts for Thai font

Reported by: Imnok Owned by: melchoyce
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

Hi there, Twenty Seventeen theme is very cool! I really love it.

To make it better with Thai font, I think we can add specific fonts as well.
Here is my suggestion.

/* Typography for Thai Font */

html[lang="th"] h1,
html[lang="th"] h2,
html[lang="th"] h3,
html[lang="th"] h4,
html[lang="th"] h5,
html[lang="th"] h6 {
line-height: 1.65;
font-family: "Sukhumvit Set", "Helvetica Neue", helvetica, arial, sans-serif;
}

html[lang="th"] body,
html[lang="th"] button,
html[lang="th"] input,
html[lang="th"] select,
html[lang="th"] textarea {
line-height: 1.8;
font-family: "Helvetica Neue", helvetica, arial, sans-serif;
} 

Attachments (4)

38937.diff (676 bytes) - added by Presskopp 5 years ago.
38937.1.diff (667 bytes) - added by netweb 5 years ago.
38937.2.diff (686 bytes) - added by melchoyce 5 years ago.
output_WAeUvi.gif (526.5 KB) - added by Presskopp 5 years ago.

Download all attachments as: .zip

Change History (25)

@Presskopp
5 years ago

#1 @Presskopp
5 years ago

  • Keywords has-patch added

corresponding patch

@netweb
5 years ago

#2 @netweb
5 years ago

Patch 38937.1.diff correctly capitalises Helvetica and Arial

#3 follow-up: @davidakennedy
5 years ago

  • Owner set to melchoyce
  • Status changed from new to assigned

Hey @Imnok! Welcome, and thank you for the thoughtful suggestion. Why would a specific font stack make things better in this case?

I'll leave it to @melchoyce, who led the language-specific CSS work, to make the call here. I'm okay with trying to get this in this release, if it dramatically improves the experience.

#4 @davidakennedy
5 years ago

  • Keywords reporter-feedback added

#5 follow-up: @melchoyce
5 years ago

Is Sukhumvit Set a font installed by default on Windows? (I don't see it on Mac.) Wondering because we're only including system fonts for non-latin languages, rather than including extra web fonts that people would either need to download, or we'd need to serve alongside the Franklin Libre in the theme.

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


5 years ago

#7 in reply to: ↑ 3 @Imnok
5 years ago

Thanks! @davidakennedy. Because the Sukhumvit font I recommend is creating for Thai alphabet, so it's properly rendered, beautiful, modern and easy to read as well.

#8 in reply to: ↑ 5 @Imnok
5 years ago

Hi @melchoyce. No, it isn't. "Sukhumvit Set" font is a default font comes with OS X (Mac) - here is a reference https://en.wikipedia.org/wiki/List_of_typefaces_included_with_macOS#New_fonts_added_with_OS_X_10.10_Yosemite

Version 0, edited 5 years ago by Imnok (next)

#9 follow-up: @melchoyce
5 years ago

"Sukhumvit Set" font is a system font comes with OS X (Mac)

Sorry, you're right, I'm seeing it on my font list now. As far as I can tell, it looks very nice. I think it would be a good enhancement.

It looks like 38937.1.diff is missing Sukhumvit Set in the second font declaration — I'm seeing it applied to headers, but not body text. I'll upload another patch.

@melchoyce
5 years ago

#10 in reply to: ↑ 9 @Imnok
5 years ago

That's perfect! Thank you @melchoyce.

#11 @Imnok
5 years ago

  • Keywords reporter-feedback removed

#12 @Presskopp
5 years ago

Attached a gif showing Windows 7 and font "Leelawadee", which seems to be the default system font in Windows 7 for Thai.

#13 @davidakennedy
5 years ago

@Imnok Thanks for the explanation! What do you think about Leelawadee (Win7) and Leelawadee UI (Win8)? We probably should have a nice font for the Windows OS.

#14 @Imnok
5 years ago

Thanks @Presskopp for suggestion!

I'd asked people around. Between 3 types of system fonts on Windows OS (Leelawadee, Arial and San-serif), it seems we prefer "Arial" and "San-serif" font. Furthermore, Leelawadee font still has a small letter-spacing on small sizes which it's hard to read on Thai characters.

#15 follow-up: @davidakennedy
5 years ago

@melchoyce What are your thoughts on the feedback from @Imnok in ticket:38937#comment:14?

#16 in reply to: ↑ 15 @melchoyce
5 years ago

Replying to davidakennedy:

@melchoyce What are your thoughts on the feedback from @Imnok in ticket:38937#comment:14?

Let's add Sukhumvit Set but leave out Leelawadee.

#17 @davidakennedy
5 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.7

Thanks @Imnok and @melchoyce!

I think we should get this in for 4.7 because it's a visual change, and better to do that now, rather than later after users make child themes, customizations, etc. based off the theme.

38937.2.diff looks good to go to me.

This ticket was mentioned in Slack in #core by davidakennedy. View the logs.


5 years ago

#19 @helen
5 years ago

  • Keywords dev-reviewed added

#20 @davidakennedy
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39482:

Twenty Seventeen: Add specific font stack for Thai language

Improves legability and design for users viewing the theme with Thai language.

Props imnok, netweb, melchoyce.

Fixes #38937.

#21 @helen
5 years ago

In 39484:

Twenty Seventeen: Add specific font stack for Thai language

Improves legability and design for users viewing the theme with Thai language.

Props imnok, netweb, melchoyce.

Fixes #38937 for the 4.7 branch.

Note: See TracTickets for help on using tickets.