#38939 closed defect (bug) (fixed)
Twenty Seventeen: input backgrounds are only styled for webkit browsers
Reported by: | Clorith | Owned by: | laurelfulford |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
The styles for inputs are all styled with background-image: -webkit-linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0))
, this means there are situations where you may end up with dark text on dark backgrounds, for example when working with high contrast computer setups.
We need a fallback for non-webkit browsers here, Twenty Sixteen does this by defining background: #f7f7f7
Originally reported by @schamane in https://wordpress.org/support/topic/twentyseventeen-input-fields-unreadable-on-reversed-screens/
Attachments (1)
Change History (12)
#2
in reply to:
↑ 1
@
8 years ago
Replying to Presskopp:
found this in 2015, reason for double color gradient:
/* Removing the inner shadow on iOS inputs */
@Presskopp Thank you for digging this up!
#3
@
8 years ago
- Keywords has-patch added
Patch imitating Twenty Sixteen, using #fff, not #f7f7f7, because it would be nowhere else to find in Twenty Seventeen.
#4
@
8 years ago
- Milestone changed from Awaiting Review to 4.7
- Owner set to laurelfulford
- Status changed from new to assigned
This is something that definitely should be fixed. I want to note that we'll need to also ensure any color changes also work with the color schemes.
This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.
8 years ago
#6
@
8 years ago
- Keywords commit added
After further discussion with @laurelfulford on this, we’re only using a linear gradient to override Safari’s default styles. The dark scheme already has the necessary color override, so we're good there.
So thanks for the patch @Presskopp! It looks good to go.
found this in 2015, reason for double color gradient: