WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#38950 closed defect (bug) (fixed)

Twenty Seventeen: 1px of header video is visible at bottom of page

Reported by: celloexpressions Owned by: joemcgill
Milestone: 4.7 Priority: normal
Severity: minor Version: 4.7
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit dev-reviewed
Focuses: Cc:

Description

There is a 1px gap at the bottom of the front page where the header video is visible. I couldn't find exactly where it's coming from quickly, but likely a minor CSS issue.

Attachments (2)

twentyseventeen-bottom-gap-video.png (26.1 KB) - added by celloexpressions 5 months ago.
Visible gap zoomed in on Chrome/Windows 10.
38950.diff (650 bytes) - added by joemcgill 5 months ago.

Download all attachments as: .zip

Change History (11)

@celloexpressions
5 months ago

Visible gap zoomed in on Chrome/Windows 10.

@joemcgill
5 months ago

#1 @joemcgill
5 months ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to joemcgill
  • Status changed from new to accepted

I think this might be a browser rounding issue due to using relative sizes for line-heights and margins within the Twenty Seventeen theme. This can result in the outer #page container calculated to a non-integer height—leaving a little overlap where the fixed height video sticks out at the bottom. Adding 1px of padding to the bottom of the header, seems to clear this up.

#2 @joemcgill
5 months ago

38950.diff Adds 1px to the bottom of the custom header in Twenty Seventeen as outlined above.

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


5 months ago

This ticket was mentioned in Slack in #core-themes by joemcgill. View the logs.


5 months ago

#5 @davidakennedy
5 months ago

  • Keywords commit added

@joemcgill I'm good with the approach in 38950.diff. I'd say this is good to go.

This ticket was mentioned in Slack in #core by joemcgill. View the logs.


5 months ago

#7 @westonruter
5 months ago

  • Keywords dev-reviewed added

#8 @joemcgill
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39380:

Twenty Seventeen: Keep header videos from extending past footer.

This adds 1px of bottom padding to header videos to keep them from
extending past the footer at the bottom of the page.

Fixes #38950.

#9 @joemcgill
5 months ago

In 39381:

Twenty Seventeen: Keep header videos from extending past footer.

This adds 1px of bottom padding to header videos to keep them from
extending past the footer at the bottom of the page.

Fixes #38950 for 4.7 branch.

Note: See TracTickets for help on using tickets.