WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#38951 closed defect (bug) (fixed)

Twenty Seventeen: front page section placeholders toggle with theme options section but are visible initially

Reported by: celloexpressions Owned by: davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit dev-reviewed
Focuses: Cc:

Description

The front page section placeholders were intended to only be visible when the theme options section was expanded, so that the preview is an accurate representation of the front end of the site. When the theme options section is expanded, the placeholders are shown along with borders on each section, to clarify where each option is applied on the site and where additional content can be added.

Currently in trunk, the placeholders are visible when the customizer loads, then properly toggle with the theme options section's exxpanded state. They should be hidden when the customizer first loads. One could argue that the current behavior improves discoverability, but it is more likely to cause annoyance when extra section placeholders continue to show up after initial theme setup, and starter content reduces the need for placeholders showing initially.

Not milestoning yet as it needs a patch, but this should probably be in 4.7.

Attachments (3)

twentyseventeen-front-page-section-placeholder-visibility-problem.gif (482.5 KB) - added by celloexpressions 4 months ago.
38951.diff (415 bytes) - added by sstoqnov 4 months ago.
Hide front section panels on load
38951.1.diff (683 bytes) - added by sstoqnov 4 months ago.
hide twentyseventeen theme option placeholders on load

Download all attachments as: .zip

Change History (14)

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


4 months ago

#2 @davidakennedy
4 months ago

  • Milestone changed from Awaiting Review to 4.7

@sstoqnov
4 months ago

Hide front section panels on load

#3 @sstoqnov
4 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

I think that it's ok to hide them on load using twentyseventeen style.css

This ticket was mentioned in Slack in #core by helen. View the logs.


4 months ago

#5 @helen
4 months ago

This works for initial load and toggling in/out of theme options; however, when clearing a section (i.e. setting it to no page), the placeholder does not then appear. Should it? I'm a bit torn.

@sstoqnov
4 months ago

hide twentyseventeen theme option placeholders on load

#6 @sstoqnov
4 months ago

Agree, then they should be hidden using javascript, so when clearing section they will be visible again.

#7 @davidakennedy
4 months ago

  • Keywords commit added

I agree too to that @helen. Thanks @sstoqnov for the updated patch! I tested this and it works well. This should be good to go.

#8 @davidakennedy
4 months ago

  • Owner set to davidakennedy
  • Status changed from new to assigned

#9 @helen
4 months ago

  • Keywords dev-reviewed added

#10 @davidakennedy
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39417:

Twenty Seventeen: Hide front section panels on page load of Customizer.

Props sstoqnov.

Fixes #38951.

#11 @helen
4 months ago

In 39421:

Twenty Seventeen: Hide front section panels on page load of Customizer.

Props sstoqnov.

Fixes #38951 for the 4.7 branch.

Note: See TracTickets for help on using tickets.