#38951 closed defect (bug) (fixed)
Twenty Seventeen: front page section placeholders toggle with theme options section but are visible initially
Reported by: | celloexpressions | Owned by: | davidakennedy |
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch needs-testing commit dev-reviewed |
Focuses: | Cc: |
Description
The front page section placeholders were intended to only be visible when the theme options section was expanded, so that the preview is an accurate representation of the front end of the site. When the theme options section is expanded, the placeholders are shown along with borders on each section, to clarify where each option is applied on the site and where additional content can be added.
Currently in trunk, the placeholders are visible when the customizer loads, then properly toggle with the theme options section's exxpanded state. They should be hidden when the customizer first loads. One could argue that the current behavior improves discoverability, but it is more likely to cause annoyance when extra section placeholders continue to show up after initial theme setup, and starter content reduces the need for placeholders showing initially.
Not milestoning yet as it needs a patch, but this should probably be in 4.7.
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.
8 years ago
#3
@
8 years ago
- Keywords has-patch needs-testing added; needs-patch removed
I think that it's ok to hide them on load using twentyseventeen style.css
This ticket was mentioned in Slack in #core by helen. View the logs.
8 years ago
#5
@
8 years ago
This works for initial load and toggling in/out of theme options; however, when clearing a section (i.e. setting it to no page), the placeholder does not then appear. Should it? I'm a bit torn.
#6
@
8 years ago
Agree, then they should be hidden using javascript, so when clearing section they will be visible again.
Hide front section panels on load