WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#38970 closed defect (bug) (fixed)

Twenty Seventeen: Make screen-reader-text arrow Scroll Down meaningful

Reported by: rianrietveld's profile rianrietveld Owned by: davidakennedy's profile davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch commit i18n-change dev-reviewed
Focuses: accessibility Cc:

Description (last modified by rianrietveld)

The screen-reader-text Scroll Down on the arrow on the homepage can be improved to:
Scroll down to content in the Twenty Seventeen theme.

This way screen reader users will know what to expect when they use this link, now it's unclear.

Attachments (1)

38970.diff​ (2.0 KB) - added by rianrietveld 8 years ago.
text: Scroll down to content

Download all attachments as: .zip

Change History (14)

@rianrietveld
8 years ago

text: Scroll down to content

#1 @rianrietveld
8 years ago

  • Keywords has-patch added
  • Summary changed from Make text arrow Scroll Down meaningful to Make screen-reader-text arrow Scroll Down meaningful

#2 @rianrietveld
8 years ago

  • Description modified (diff)

#3 @afercia
8 years ago

  • Summary changed from Make screen-reader-text arrow Scroll Down meaningful to Twenty Seventeen: Make screen-reader-text arrow Scroll Down meaningful

This ticket was mentioned in ​Slack in #core-themes by davidakennedy. ​View the logs.
8 years ago

#5 @davidakennedy
8 years ago

  • Milestone changed from Awaiting Review to 4.7

#6 @davidakennedy
8 years ago

  • Keywords commit added
  • Owner set to davidakennedy
  • Status changed from new to assigned

Looks good to go to me. Thanks for the patch @rianrietveld!

I'll work on getting this reviewed for inclusion this release.

This ticket was mentioned in ​Slack in #core by davidakennedy. ​View the logs.
8 years ago

#8 @ocean90
8 years ago

  • Keywords i18n-change added

Adding i18n-change since we're already in string freeze.

#9 @ocean90
8 years ago

38970.diff​: Not sure if the direction down is necessary, but looks good otherwise.

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
8 years ago

#11 @helen
8 years ago

  • Keywords dev-reviewed added

#12 @davidakennedy
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39384:

Twenty Seventeen: Make screen reader text on scroll arrow more meaningful

This way screen reader users will know what to expect when they use this link.

Props rianrietveld.

Fixes #38970.

#13 @ocean90
8 years ago

In 39385:

Twenty Seventeen: Make screen reader text on scroll arrow more meaningful

This way screen reader users will know what to expect when they use this link.

Merge of [39384] to the 4.7 branch.

Props rianrietveld.
See #38970.

Note: See TracTickets for help on using tickets.