WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#38972 closed enhancement (fixed)

Twenty Seventeen: Spacing off on pages without comments

Reported by: melchoyce Owned by: laurelfulford
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:
PR Number:

Description

I only just noticed on this short page that the spacing seems to be off: https://cloudup.com/cKLghqLc79C.

There’s more space on the top of the page than the bottom (Looks like 6.5em top 3em bottom). It should be about 90px above the page, 120px below, rounded to whatever ems (probably something like 6em top 7.5em bottom, accounting for 1.5em on the last paragraph on the page — or whatever).

It seems to be fine everywhere else.

Attachments (2)

38972.patch (571 bytes) - added by laurelfulford 3 years ago.
38972.1.patch (711 bytes) - added by laurelfulford 3 years ago.

Download all attachments as: .zip

Change History (12)

#1 @melchoyce
3 years ago

  • Owner set to laurelfulford
  • Status changed from new to assigned

@laurelfulford
3 years ago

#2 @laurelfulford
3 years ago

  • Keywords has-patch added

I noticed it was tighter than ~120px on pages with comments, too (though it's more noticeable on pages without).

In 38972.patch I've added some more space to get it matching the space on posts - @melchoyce, can you let me know if you think it should be adjusted further? Thanks!

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


3 years ago

#4 @davidakennedy
3 years ago

The patch works well for me, and I don't see any issues with it. As long as @melchoyce is good with it, I'll get another committer to review it.

#5 @laurelfulford
3 years ago

Discussed the patch a bit with @melchoyce and updated in 38972.1.patch: increased the bottom padding in the original patch by a bit more, and decreased the top padding by a bit to make it closer to 90px.

This ticket was mentioned in Slack in #core by helen. View the logs.


3 years ago

#7 @davidakennedy
3 years ago

  • Keywords commit added

This latest one looks good to me.

#8 @helen
3 years ago

  • Keywords dev-reviewed added

#9 @davidakennedy
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39404:

Twenty Seventeen: Make spacing on pages without comments consistent

Previously, the top of the page had more space than the bottom, not matching the original design.

Props laurelfulford, melchoyce.

Fixes #38972.

#10 @westonruter
3 years ago

In 39405:

Twenty Seventeen: Make spacing on pages without comments consistent

Previously, the top of the page had more space than the bottom, not matching the original design.

Props laurelfulford, melchoyce.
Merges [39404] onto the 4.7 branch.
Fixes #38972 for 4.7.

Note: See TracTickets for help on using tickets.