WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38977, comment 7


Ignore:
Timestamp:
12/01/2016 04:59:11 AM (3 years ago)
Author:
rachelbaker
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38977, comment 7

    initial v1  
    1 I am concerned about the potential performance impact of reloading the schema. We *could* special case attachment, but then shouldn't we also special case `revisions`? And what about when Menu endpoints are added that use the `nav_menu_item` post type? 
     1I am concerned about the potential performance impact of reloading the schema. We *could* special case attachment, but then shouldn't we also special case the `nav_menu_item` post type when adding Menu endpoints in the future?
    22
    33Seems like, ideally, we would want to use something like a  `post_type_supports()` conditional within the schema.  Which is a bigger fix than we can get into 4.7, which brings me to question "is anything broken here?"