Twenty Seventeen: Header text color isn't always applied

[ocean90]

This is an issue with the CSS specificity.

Issue 1:

• Clear existing theme mods (wp eval "remove_theme_mods();")
• Go to the customizer and the colors section
• Switch to "Custom" and choose a color
• Notice that the preview has the color applied
• Click Save & Publish
• Close customizer and view the front page
• Bug: The header text has the default color

Issue 2:

• Clear existing theme mods (wp eval "remove_theme_mods();")
• Go to the customizer and remove the header image
• Default header color is now #222
• Go to the colors section
• Change header text color to red
• Click Save & Publish
• Reload customizer (CMD/CTRL+R)
• Go to the colors section
• Select "Dark"
• Bug: The preview has the default color and the header text control still shows red
• Change header text color to yellow
• Notice that the preview has the color applied
• Click Save & Publish
• Close customizer and view the front page
• Bug: The header text has the default color

[davidakennedy]

Thanks for the report!

Looks like this is an issue in the CSS applied if you select a custom header text color. This:

.site-title a,
	body.has-header-image .site-title a,
	.site-description,
	body.has-header-image .site-description {
		color: #<?php echo esc_attr( $header_text_color ); ?>;
	}

Needs to also have the additional color scheme classes: .colors-dark and .colors-custom.

[laurelfulford]

In 38980.patch​, I made the custom-header.php selectors a lot more specific as suggested. It seems to do the trick - let me know if it needs further adjusting!

[ocean90]

38980.patch​ looks good to me.

[davidakennedy]

In 39397:

Twenty Seventeen: Make sure header text color is applied when color schemes are active.

Props laurelfulford, ocean90.

Fixes #38980.

[helen]

In 39398:

Twenty Seventeen: Make sure header text color is applied when color schemes are active.

Props laurelfulford, ocean90.

Merges [39397] to the 4.7 branch.
Fixes #38980 for 4.7.