REST API: Some orderby parameters are broken

[jnylen0]

The orderby parameters id and slug are currently broken for posts. Since they don't map directly to WP_Query values, and there is no code to translate them, they don't do anything.

The include parameter works, but only if a list of IDs is specified via the include parameter. We should return an error for orderby=include without this parameter, like we do for orderby=relevance without search.

[ChopinBach]

@jnylen0

If you aren't already prepping a patch I can do a patch for it. It should be a lot cleaner than my last attempt.

[joehoyle]

I guess we should remove id and slug given there's no simple way to achieve this with WP_Query.

[jnylen0]

I haven't started on a patch for this yet.

It looks like we can just map id → ID and slug → name, like we already do for include → post__in. Presumably this is how it worked at one point.

I think this issue shows that we also need to add tests for the actual SQL - using the posts_orderby filter seems like a good way to achieve this. In fact if we have that in place then we could probably drop the testing of results lists altogether which can be a bit tricky.

I'm also wondering if there is similar breakage in the orderby parameters of other endpoints.

[ChopinBach]

Adds an error when include orderby is specified without an include parameter. The id and slug orderby parameters now properly map to their correct fields ID and post_name. There may still be more problems surrounding orderby, but this addressed the ones reported in this ticket.

[ChopinBach]

Adds an error when include orderby is specified without an include parameter. The id and slug orderby parameters now properly map to their correct fields ID and post_name. There may still be more problems surrounding orderby, but this addressed the ones reported in this ticket. This is a slightly cleaner approach, and makes future maintenance of the orderby params simpler.

[rachelbaker]

We are in a string freeze for 4.7 and cannot introduce a new error message.

I see two options here:

1. We ignore the include orderby value if the request does not include the related include parameter.
2. We remove support for the 'orderby' => 'include' for 4.7.

I would like to do Option #1 if possible, but we are running out of time here folks.

[jnylen0]

Reuse an existing error string; rename mappings to $orderby_mappings

[jnylen0]

Option 3: reuse ​an existing error message for 4.7 and clean it up in 4.8.

Done in 38985.3.diff​; also renamed $orderby_possibles → $orderby_mappings to match $parameter_mappings in the same file.

[pento]

I'm cool with 38985.3.diff​, there's nothing insane that will cause everything to explode.

[rachelbaker]

+1 on 38985.3.diff​

[rachelbaker]

Fixed in [39440] and [39441] - referencing the wrong ticket number.