Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38995, comment 8


Ignore:
Timestamp:
12/01/2016 06:32:45 PM (9 years ago)
Author:
laurelfulford
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38995, comment 8

    initial v1  
    1313
    14144. I re-added a change to adjustScrollClass() in global.js from [attachment:38995.patch]:[[br]][[br]]Originally we were checking for the presence of `.custom-header-image` (now `.custom-header-media`) to decide when to make the menu ‘sticky’. But there’s an edge-case issue: it happens when a site has a video but no header image, and you view the site on a screen size just above the tablet breakpoint (769px - 899px wide). The video isn’t visible at this screen size, but the JavaScript thinks it is because `.custom-header-media` is there, causing it to miscalculate where the menu should be stuck.[[br]][[br]]I’ve switched it to check for the `.has-header-video` or `.has-header-image` classes instead.[[br]][[br]]I didn’t comment on this specifically with the last patch, so it wasn’t clear why I had made that change - sorry about that!
     15
     16Further testing is appreciated, to make sure I didn’t miss anything!