WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 9 months ago

Last modified 9 months ago

#38998 closed defect (bug) (fixed)

Inconsistencies on admin update page, 'up-to-date' vs 'up to date'

Reported by: aprea Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: trivial Version: 4.6.1
Component: I18N Keywords: good-first-bug has-patch needs-refresh
Focuses: Cc:

Description

The WordPress Update page in wp-admin includes both the phrases 'up-to-date' and 'up to date'. We should decide on one format to keep things consistent.

Attachments (3)

Screen Shot 2016-12-01 at 10.03.57 am.png (18.2 KB) - added by aprea 3 years ago.
38998.diff (673 bytes) - added by socalchristina 14 months ago.
38998.1.diff (1.7 KB) - added by Hareesh Pillai 9 months ago.
Patch refreshed. Updated the 3 inline documentation comments as well.

Download all attachments as: .zip

Change History (19)

#1 @aprea
3 years ago

  • Severity changed from normal to trivial

#2 @SergeyBiryukov
3 years ago

  • Component changed from Administration to I18N
  • Keywords close added

Hi @aprea, welcome to Trac! Thanks for the ticket.

This is an issue with the en_GB translation:
https://translate.wordpress.org/projects/wp/dev/admin/en-gb/default?filters%5Bterm%5D=up+to+date

Of the six strings containing "up to date", two are translated with "up-to-date", and the rest are left as is.

@garyj: Could you take a look?

#3 @aprea
3 years ago

FYI I'm using the en_AU translation.

#4 @netweb
3 years ago

For #en-au @aprea they are here: https://translate.wordpress.org/projects/wp/dev/admin/en-au/default?filters%5Bterm%5D=up+to+date

If you click details and update the strings as I needed I'll approve them

#5 @GaryJ
3 years ago

I'll take this to the en_GB team and we'll make them consistent.

#6 @desrosj
15 months ago

  • Keywords needs-patch good-first-bug added; close removed
  • Milestone changed from Awaiting Review to Future Release

It looks like the en_GB translations are now all reflecting up to date, but there are still some up-to-date translations in en_AU.

There is also one stray `up-to-date` remaining in core, as well as 3 inline documentation comments with up-to-date.

#7 @socalchristina
14 months ago

Hi,

This is my first attempt at open source. I hope I'm on the right track here.

(It looks like the en_GB translations are now all reflecting up to date, but there are still some up-to-date translations in en_AU.)

I updated the strings in the en-au in https://translate.wordpress.org/projects/wp/dev/admin/en-au/default?filters%5Bterm%5D=up+to+date

(There is also one stray up-to-date remaining in core, as well as 3 inline documentation comments with up-to-date.)

I changed up-to-date to display as up to date. I did not see 3 inline documentation comments with up-to-date.

@desrosj, can I get some clarification on the inline comments, please?

38998.diff

Last edited 14 months ago by socalchristina (previous) (diff)

#8 @socalchristina
14 months ago

  • Keywords has-patch added; needs-patch removed

@Hareesh Pillai
9 months ago

Patch refreshed. Updated the 3 inline documentation comments as well.

#9 @Hareesh Pillai
9 months ago

38998.1 updates the pending strings.
Core is now up to date!!

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


9 months ago

#11 @SergeyBiryukov
9 months ago

  • Milestone changed from Future Release to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#12 follow-up: @garrett-eclipse
9 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.3 to Future Release

Hi @hareesh-pillai nice to e-meet you in scrub - https://wordpress.slack.com/archives/C02RQBWTW/p1568268801349200

Reviewing this the only string that makes sense to change here would be the first comment;
Replace hrefs of attachment anchors with up to date permalinks.

The other all use the proper up-to-date "adjective phrase that is used as a synonym for current";
Reference - https://writingexplained.org/up-to-date-hyphenated

Cheers

#13 @SergeyBiryukov
9 months ago

  • Milestone changed from Future Release to 5.3

#14 in reply to: ↑ 12 @SergeyBiryukov
9 months ago

Replying to garrett-eclipse:

Reviewing this the only string that makes sense to change here would be the first comment;
Replace hrefs of attachment anchors with up to date permalinks.

The other all use the proper up-to-date "adjective phrase that is used as a synonym for current";
Reference - https://writingexplained.org/up-to-date-hyphenated

Hmm, my understanding is vice versa :) Per the examples in that article, "up-to-date permalinks" seems correct as is, while the other instances should be corrected to "up to date", making them consistent with some other existing strings: "Your plugins are all up to date", "This theme is already installed and is up to date", etc.

#15 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46096:

Text Changes: Correct "up-to-date" vs. "up to date" usage in a database update string and inline comments.

  • "Up to date" is an adverb phrase that describes an action that brings something in line with the latest information.
  • "Up-to-date" is an adjective phrase that is used as a synonym for "current".

Props socalchristina, hareesh-pillai, garrett-eclipse, desrosj, aprea.
Fixes #38998.

#16 in reply to: ↑ description @marybaum
9 months ago

Replying to aprea:

The WordPress Update page in wp-admin includes both the phrases 'up-to-date' and 'up to date'. We should decide on one format to keep things consistent.

The use of hyphens depends on how we're using the phrase in a sentence.

If we're using the phrase as a modifier -- adjective or adverb, for instance, we use the hyphens.

"Please use the most up-to-date version you can run."

*up-to-date* modifies the noun *version*. *most* modifies *up-to-date*

If the phrase on its own is a noun, then we lose the hyphens.

"Is that installation up to date?"

The phrase stands on its own, because it's not modifying anything.

Note: See TracTickets for help on using tickets.