Impossible to access current priority with WP_Hook

[Rarst]

While there was never a public API for it, the specifics of implementation had previously allowed to access current priority within a hook via key( $wp_filter[ current_filter() ] ).

This seems to no longer be a case with 4.7 implementation based on WP_Hook which both changes what this expression returns (string callbacks) and seems to hide priority data in private property.

Given that implementation both breaks existing way to do it and doesn't open a new way to it breaks all code that needs access to current priority state without alternative.

[dd32]

For reference; Do you know of any public projects which have been utilising this?

[Rarst]

Replying to dd32:

For reference; Do you know of any public projects which have been utilising this?

My Laps profiler plugin got exploded by this ​https://github.com/Rarst/laps

[toscho]

There are also some often reused snippets on WordPress Stack Exchange, this one for example: ​How to force function to run as the last one when saving the post?

[pento]

While this has never really been supported behaviour (particularly with how broken nested hooks were), I don't think it's unreasonable to explicitly allow access to the currently running priority of the current filter.

@Rarst: How do you feel about 39007.diff​? To take your example, you'd use it as: $wp_filter[ current_filter() ]->current_priority().

[Rarst]

Not sure about implementation, but API seems to make sense. :)

One question is would current_priority() function make sense to complement current_filter() for procedural access? That would make conditional logic less clunky (if have new function just use it, otherwise do old thing).

[pento]

Adding a current_priority() function seems like it's a bit more than is necessary.

For conditional logic, class_exists( 'WP_Hook' ) is a reasonable test, this is what Batcache uses, for example - it's technically not correct for 4.7 betas that don't have the ::current_priority() method, but I don't think that should be a big issue. :-)

[pento]

39007.2.diff​ adds unit tests.

[pento]

In 39430:

Plugins: Add a current_priority() method to WP_Hook.

This allows plugins to determine the currently running priority of a filter.

Fixes #39007.

[pento]

In 39431:

Plugins: Add a current_priority() method to WP_Hook.

This allows plugins to determine the currently running priority of a filter.

Merges [39430] to the 4.7 branch.

Fixes #39007.

[SergeyBiryukov]

#33886 was marked as a duplicate.