WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#39013 closed defect (bug) (fixed)

Merge similar translation strings in the rest API

Reported by: ramiy's profile ramiy Owned by: ocean90's profile ocean90
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Comments Keywords: has-patch commit dev-reviewed
Focuses: rest-api Cc:

Description

I found one more translation string in the new REST API that can be merged with an existing string.

This does not effect the soft string freeze, we don't add new translation strings.

Attachments (2)

more-similar-strings.png​ (25.4 KB) - added by ramiy 8 years ago.
39013.patch​ (671 bytes) - added by ramiy 8 years ago.

Download all attachments as: .zip

Change History (12)

@ramiy
8 years ago

@ramiy
8 years ago

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
8 years ago

#2 @ramiy
8 years ago

  • Keywords has-patch added

#3 @swissspidy
8 years ago

Shouldn't we rather use 'post' instead of 'item'? See #38811.

#4 @ramiy
8 years ago

@swissspidy I remember what we did in #38811. But this is a different case.

In this case we are talking about "comments" and "trackbacks", those are not "API Resources".

Besides, comments & trackbacks can be used in any post type, not only posts.

In my opinion, changing to "items" is the best solution.

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
8 years ago

#6 @ocean90
8 years ago

  • Keywords commit dev-feedback added
  • Milestone changed from Awaiting Review to 4.7

Let's do 39013.patch​.

#7 @ocean90
8 years ago

  • Component changed from REST API to Comments

#8 @ocean90
8 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 39508:

Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.

Props ramiy.
Fixes #39013.

#9 @ocean90
8 years ago

In 39509:

Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.

Merge of [39508] to the 4.7 branch.

Props ramiy.
See #39013.

#10 @ocean90
8 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Reviewed by @helen and @pento, see ​https://wordpress.slack.com/archives/core/p1480968563000280

Note: See TracTickets for help on using tickets.