WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#39013 closed defect (bug) (fixed)

Merge similar translation strings in the rest API

Reported by: ramiy Owned by: ocean90
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Comments Keywords: has-patch commit dev-reviewed
Focuses: rest-api Cc:

Description

I found one more translation string in the new REST API that can be merged with an existing string.

This does not effect the soft string freeze, we don't add new translation strings.

Attachments (2)

more-similar-strings.png (25.4 KB) - added by ramiy 11 months ago.
39013.patch (671 bytes) - added by ramiy 11 months ago.

Download all attachments as: .zip

Change History (12)

@ramiy
11 months ago

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


11 months ago

#2 @ramiy
11 months ago

  • Keywords has-patch added

#3 @swissspidy
11 months ago

Shouldn't we rather use 'post' instead of 'item'? See #38811.

#4 @ramiy
11 months ago

@swissspidy I remember what we did in #38811. But this is a different case.

In this case we are talking about "comments" and "trackbacks", those are not "API Resources".

Besides, comments & trackbacks can be used in any post type, not only posts.

In my opinion, changing to "items" is the best solution.

This ticket was mentioned in Slack in #core by helen. View the logs.


11 months ago

#6 @ocean90
11 months ago

  • Keywords commit dev-feedback added
  • Milestone changed from Awaiting Review to 4.7

Let's do 39013.patch.

#7 @ocean90
11 months ago

  • Component changed from REST API to Comments

#8 @ocean90
11 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 39508:

Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.

Props ramiy.
Fixes #39013.

#9 @ocean90
11 months ago

In 39509:

Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.

Merge of [39508] to the 4.7 branch.

Props ramiy.
See #39013.

#10 @ocean90
11 months ago

  • Keywords dev-reviewed added; dev-feedback removed
Note: See TracTickets for help on using tickets.