WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#39017 closed defect (bug) (fixed)

REST API: Use the correct error message text when attempting to edit a term that the user cannot edit

Reported by: johnbillion's profile johnbillion Owned by: pento's profile pento
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Taxonomy Keywords: has-patch commit dev-reviewed
Focuses: rest-api Cc:

Description

WP_REST_Terms_Controller::update_item_permissions_check() should use the singular form in its error message when a user doesn't have permission to update a term.

This does not introduce a new string because this string is used in wp_xmlrpc_server::wp_editTerm() already.

Attachments (3)

39017.patch​ (748 bytes) - added by ramiy 9 years ago.
39017.diff​ (755 bytes) - added by johnbillion 9 years ago.
edit.png​ (126.5 KB) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (12)

@ramiy
9 years ago

#1 @ramiy
9 years ago

  • Keywords has-patch added; needs-patch removed

@johnbillion
9 years ago

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
9 years ago

#3 @johnbillion
9 years ago

@ramiy Jinx! :-)

#4 @ramiy
9 years ago

:-)

I was working on a related subject, see my other tickets: #39013, #39014, #39016

Last edited 9 years ago by ramiy (previous) (diff)

#5 @pento
9 years ago

  • Keywords commit dev-feedback added

Looks good.

@ramiy
9 years ago

#6 @ramiy
9 years ago

I think we can merge more similar translation strings ​of this kind.

Last edited 9 years ago by ramiy (previous) (diff)

#7 @nacin
9 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#8 @pento
9 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 39460:

REST API: Use the correct error message when editing a single term.

Props ramiy, johnbillion.
Fixes #39017.

#9 @pento
9 years ago

In 39461:

REST API: Use the correct error message when editing a single term.

Merges [39460] to the 4.7 branch.

Props ramiy, johnbillion.
Fixes #39017.

Note: See TracTickets for help on using tickets.