#39022 closed defect (bug) (fixed)
Invalid query parameters in `WP_Customize_Manager`
| Reported by: | dlh | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.7 |
| Component: | Customize | Version: | 4.7 |
| Severity: | normal | Keywords: | has-patch commit has-unit-tests dev-reviewed |
| Cc: | Focuses: |
Description
WP_Customize_Manager passes the number parameter to some WP_Query instances, but, as far as I can tell, WP_Query doesn't accept number.
For instance, in trunk running Twenty Seventeen, after this query: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php#L1015
The value of $existing_posts_query->request is: "SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_name IN [...] ORDER BY wp_posts.post_date DESC LIMIT 0, 10"
I assume the LIMIT wasn't supposed to be there, so the attached patch would replace number with posts_per_page.
Attachments (2)
Change History (8)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Tweak starter content unit test to ensure fix works