Invalid query parameters in `WP_Customize_Manager`
|Reported by:||dlh||Owned by:||westonruter|
|Component:||Customize||Keywords:||has-patch commit has-unit-tests dev-reviewed|
WP_Customize_Manager passes the number parameter to some WP_Query instances, but, as far as I can tell, WP_Query doesn't accept number.
For instance, in trunk running Twenty Seventeen, after this query: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php#L1015
The value of $existing_posts_query->request is: "SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_name IN [...] ORDER BY wp_posts.post_date DESC LIMIT 0, 10"
I assume the LIMIT wasn't supposed to be there, so the attached patch would replace number with posts_per_page.
Change History (8)
4 months ago
- Milestone changed from Awaiting Review to 4.7
- Owner set to westonruter
- Status changed from new to accepted