WordPress.org

Make WordPress Core

#39027 closed defect (bug) (fixed)

Restore wp-includes/class-feed.php

Reported by: Frank Klein Owned by: pento
Milestone: 4.7 Priority: normal
Severity: critical Version: 4.7
Component: Feeds Keywords: commit dev-reviewed
Focuses: Cc:

Description

r38374 removed the wp-includes/class-feed.php file. This leads to fatal errors for any code directly including this file.

This file should be restored, and a deprecated file notice should be added.

Change History (17)

#1 @ocean90
11 months ago

This applies to all removed files IMO:

  • 'wp-admin/includes/class-wp-upgrader-skins.php',
  • 'wp-includes/class-feed.php',
  • 'wp-includes/locale.php',
  • 'wp-includes/session.php',

See my comment for class-wp-upgrader-skins.php: ticket:37827:19.

#2 @Frank Klein
11 months ago

I agree. Feel free to change the ticket to reflect the larger scope.

#3 @johnbillion
11 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.7
  • Severity changed from normal to critical

This ticket was mentioned in Slack in #core by helen. View the logs.


11 months ago

#5 @peterwilsoncc
11 months ago

Key commits:

wp-admin/includes/class-wp-upgrader-skins.php
r38379 - full revert

wp-includes/class-feed.php
r38374 - partial revert

  • deprecated files
  • deleted file
  • wp-includes/feed.php changes remain

wp-includes/locale.php
r38364 - partial

wp-includes/session.php
r38373 - partial

#6 @dd32
11 months ago

This applies to all removed files IMO:

I came here hoping to say that I thought we only needed to do class-feed.php and class-wp-upgrader-skins.php, but after looking at the files in 4.6, I agree that restoring all 4 as deprecated files which include the new ones is required. Both locale.php and session.php previously had class definitions.

#7 @pento
11 months ago

  • Owner set to pento
  • Status changed from new to assigned

#8 @pento
11 months ago

In 39449:

Load: Re-add class-feed.php.

class-feed.php is occasionally included directly by custom external code, so should continue to be available. This is deprecated in favour of calling fetch_feed(), however..

Partial revert of [38374].
See #36335, #39027.

#9 @pento
11 months ago

In 39450:

Load: Re-add class-wp-upgrader-skins.php.

class-wp-upgrader-skins.php is occasionally included directly by custom external code, so should continue to be available. This is deprecated in favour of including class-wp-upgrader.php, instead.

Revert of [38379].
See #36335, #39027.

#10 @pento
11 months ago

In 39453:

Load: Re-add session.php.

session.php is occasionally included directly by custom external code, so should continue to be available. This behaviour is deprecated.

Partial revert of [38373].
See #36335, #39027.

#11 follow-up: @pento
11 months ago

  • Keywords commit dev-feedback added

locale.php has not been re-added, as including it by itself would've caused fatals.

[39450], [39451] and [39453] are ready for backport to the 4.7 branch.

#12 in reply to: ↑ 11 @pento
11 months ago

  • Keywords needs-patch removed

Replying to pento:

locale.php has not been re-added, as including it by itself would've caused fatals.

This was a lie, @nacin called me out. And I would have gotten away with it too, if it weren't for you meddling kids.

#13 @pento
11 months ago

In 39455:

Load: Re-add locale.php.

locale.php is occasionally included directly by custom external code, so should continue to be available. This behaviour is deprecated.

Partial revert of [38364].
See #37827, #39027.

#14 @pento
11 months ago

[39449], [39450], [39453], and [39455] are ready for backport.

#15 @pento
11 months ago

In 39456:

Load: No-op locale.php

After re-adding locale.php in [39455], remove the content of the file so that it can't cause errors in the event of something loading it early in the WordPress load process.

See #39027.

#16 @dd32
11 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Cleared for backport from me.

#17 @pento
11 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39459:

Load: Re-add class-wp-upgrader-skins.php, class-feed.php, locale.php, and session.php.

Several files were removed during 4.7 that can be loaded externally, so we need to keep them, though their use is now deprecated.

Merges [39449], [39450], [39453], [39455], and [39456] to the 4.7 branch.
Fixes #39027.

Note: See TracTickets for help on using tickets.