Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#39032 closed defect (bug) (fixed)

When saving Custom CSS, preserve the original version in the revision history.

Reported by:	georgestephanis	Owned by:	westonruter
Priority:	normal	Milestone:	4.7
Component:	Customize	Version:	4.7
Severity:	major	Keywords:	has-patch has-unit-tests commit dev-reviewed
Cc:		Focuses:

Description

Related: #30854

When saving CSS revisions via wp_update_custom_css_post() the initial css is lost, and only subsequent updates are versioned in revisions in the database.

To avoid data loss, @adamsilverstein demonstrated that calling wp_update_post( $post ) immediately after insertion can create the revision correctly as a stopgap measure here: https://core.trac.wordpress.org/attachment/ticket/30854/test_wp_first_revision_is_not_lost.2.diff

This is only a targeted fix, and will not preserve the first revision of posts managed via the new WP REST API endpoints.

Attachments (6)

39032.diff (449 bytes ) - added by georgestephanis 10 years ago.
39032.2.diff (456 bytes ) - added by georgestephanis 10 years ago.
39032.3.diff (504 bytes ) - added by georgestephanis 10 years ago.
39032.4.diff (688 bytes ) - added by westonruter 10 years ago.
39032.with-tests.diff (1.5 KB ) - added by georgestephanis 10 years ago.
39032.5.diff (2.0 KB ) - added by westonruter 10 years ago.

Download all attachments as: .zip

Change History (12)

@georgestephanis
10 years ago

Attachment 39032.diff added

#1 @westonruter
10 years ago

Milestone Awaiting Review → 4.7
Owner set to georgestephanis
Status new → assigned

The scope of the patch makes sense for 4.7, except we should use wp_save_post_revision().

Last edited 10 years ago by westonruter (previous) (diff)

@georgestephanis
10 years ago

Attachment 39032.2.diff added

#2 @westonruter
10 years ago

Owner changed from georgestephanis to westonruter
Status assigned → accepted

@georgestephanis
10 years ago

Attachment 39032.3.diff added

@westonruter
10 years ago

Attachment 39032.4.diff added

@georgestephanis
10 years ago

Attachment 39032.with-tests.diff added

@westonruter
10 years ago

Attachment 39032.5.diff added

#3 @westonruter
10 years ago

Keywords has-unit-tests commit dev-feedback added

#4 @helen
10 years ago

Keywords dev-reviewed added; dev-feedback removed

#5 @westonruter
10 years ago

Resolution → fixed
Status accepted → closed

Customize: Ensure a custom_css post insertion gets an initial post revision.

Props georgestephanis, westonruter.
See #30854, #38672, #35395.
Fixes #39032.

#6 @westonruter
10 years ago

Customize: Ensure a custom_css post insertion gets an initial post revision.

Merges [39477] onto 4.7 branch.
Props georgestephanis, westonruter.
Fixes #39032 for 4.7.

Note: See TracTickets for help on using tickets.

Download in other formats: