WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 4 and Version 5 of Ticket #39043, comment 7


Ignore:
Timestamp:
12/04/2016 11:57:45 PM (9 years ago)
Author:
lots.0.logs
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39043, comment 7

    v4 v5  
    1 Requests supports this out of the box. We shouldn't make something that is an option in requests impossible to use without extending the `WP_Http` class and overriding its `request()` method. Again, all we have here are a bunch of opinions about disliking HTTP `GET`requests being made with a data payload. If you dislike it, then obviously don't do it. The patch I submitted simply makes it possible to use an option which is already supported in the Requests library. '''It does not change the default behavior of the WP HTTP API in any way.'''
     1Requests supports this out of the box. We shouldn't make something that is an option in Requests impossible to use without extending the `WP_Http` class and overriding its `request()` method. Again, all we have here are a bunch of opinions about disliking HTTP `GET`requests being made with a data payload. If you dislike it, then obviously don't do it. The patch I submitted simply makes it possible to use an option which is already supported in the Requests library. '''It does not change the default behavior of the WP HTTP API in any way.'''