W3C Validator warning: Attribute aria-required is unnecessary for elements that have attribute required.

[henry.wright]

File: wp-includes/comment-template.php

Screenshot incoming.

[davidakennedy]

Thanks @henry.wright for the ticket!

A few notes:

• This is a warning, and not an error, so it's not an immediate problem.
• I believe the form contains both because there was a time that having both meant a wider range of support for both browsers and assistive technology.
• This is something the accessibility team needs to discuss to decide if it's the right time to remove one of these.

[afercia]

Yep there was a time when both were needed. Today, it's safe to use just required. Instead, aria-required is for custom, non-native, controls. Also, just stumbled upon a good feedback from Adrian Roselli:
​https://stackoverflow.com/a/37975985

[lakenh]

As discussed in the ticket and meetings, the aria-required attribute was removed from this template, leaving only required.

This patch only covers the particular file that this ticket is about; there very well could be other areas in WordPress that use both of these attributes.

[audrasjb]

Hi and thanks for the patch @lakenh
Tested and looks good to me :)

The only other place I found both aria-required and required attributes is wp-admin/includes/media.php, but it will need a separated ticket.

[SergeyBiryukov]

In 42758:

Comments: Remove unnecessary aria-required attribute from comment_form(), added with the function in [12810].

At the time, having both required and aria-required meant a wider range of support for browsers and assistive technology. Today, it's safe to use just required.

Props lakenh, afercia, davidakennedy, henry.wright.
Fixes #39045.

[danieltj]

As per today's bug scrub, moving this forward for inclusion in 4.9.5.

[ocean90]

In 42849:

Comments: Remove unnecessary aria-required attribute from comment_form(), added with the function in [12810].

At the time, having both required and aria-required meant a wider range of support for browsers and assistive technology. Today, it's safe to use just required.

Merge of [42758] to the 4.9 branch.

Props lakenh, afercia, davidakennedy, henry.wright.
Fixes #39045.