Make WordPress Core

Opened 7 years ago

Closed 2 years ago

#39048 closed defect (bug) (invalid)

undefined return array var being passed to wp_parse_str

Reported by: pbearne's profile pbearne Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:


I spotted that the array being passed by ref is not be set in all places in core

This patch fixes that

#WCUS contrib day

Attachments (3)

wp_parse_str_undifeied_vars.patch (2.7 KB) - added by pbearne 7 years ago.
wp_parse_str_undifeied_vars.2.patch (2.2 KB) - added by pbearne 7 years ago.
fixed patch remove other changes
wp_parse_str_undifeied_vars.3.patch (2.3 KB) - added by pbearne 7 years ago.
fix the if block

Download all attachments as: .zip

Change History (6)

7 years ago

fixed patch remove other changes

#1 @adamsilverstein
7 years ago

@pbearne Thanks for the patch. I'm not certain I understand what issue this is resolving. Does not setting these arrays beforehand cause a PHP warning or error? A unit test demonstrating that would be immensely helpful here.

Note that generally code refactoring should not be done just because we can.

#2 @swissspidy
7 years ago

  • Version trunk deleted

7 years ago

fix the if block

#3 @SergeyBiryukov
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hi there, thanks for the patch!

Unless I'm missing something, for variables passed by reference to there is no need to create them in advance.

Per the PHP manual:

If you assign, pass, or return an undefined variable by reference, it will get created.

This is similar to the $matches parameter of preg_match(), we don't generally define that in advance either.

Note: See TracTickets for help on using tickets.