undefined return array var being passed to wp_parse_str

[pbearne]

I spotted that the array being passed by ref is not be set in all places in core

This patch fixes that

#WCUS contrib day

[pbearne]

fixed patch remove other changes

[adamsilverstein]

@pbearne Thanks for the patch. I'm not certain I understand what issue this is resolving. Does not setting these arrays beforehand cause a PHP warning or error? A unit test demonstrating that would be immensely helpful here.

Note that generally ​code refactoring should not be done just because we can.

[pbearne]

fix the if block

[SergeyBiryukov]

Hi there, thanks for the patch!

Unless I'm missing something, for variables passed by reference to there is no need to create them in advance.

Per the ​PHP manual:

If you assign, pass, or return an undefined variable by reference, it will get created.

This is similar to the $matches parameter of preg_match(), we don't generally define that in advance either.