WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39053, comment 7


Ignore:
Timestamp:
04/12/2017 01:11:38 AM (4 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #39053, comment 7

    initial v1  
    77On user POSTed values or GET query parameters? Do we use it again very late in `$wpdb` before database writes occur? If all we want to do is make sure a numeric variable is within the boundaries of what's allowed inside a `BIGINT(20) unsigned` database column, does it make sense to do that high-up in user-land or deep in the kernel?
    88
     9If it's as a replacement for `absint()` or `intval()`, it may cause breakage if third-party code does not already discriminate between negative numbers and suddenly core changes the value mid-request.
     10
    911We wouldn't want to use it everywhere, because function calls are slower than simple type-casts, and add to that the additional mathematical comparison logic against known large integers, and there's not a ton of value in repeatedly checking that every object's ID is a sane value.