WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#39057 closed defect (bug) (fixed)

FTP credentials form doesn't display the SSH2 fields on the Updates screen

Reported by: afercia Owned by: dd32
Milestone: 4.7.1 Priority: normal
Severity: normal Version: 4.6
Component: Upgrade/Install Keywords: has-screenshots shiny-updates has-patch
Focuses: Cc:

Description

The FTP credentials form is used both in the Plugins/Themes screens (where it's in a modal window) and in the Updates screen. When it's displayed inside the modal, selecting the SSH2 radio button makes the Authentication Keys fields appear:

https://cldup.com/ltG5jB7V3O.png

https://cldup.com/cY7tzqAK5D.png

On the Updates screen instead, when selecting the SSH2 radio button nothing happens:

https://cldup.com/is34DsUkk6.png

Worth reminding before 4.6 the two Authentication Keys fields were in a different position (above the radio buttons) and always displayed on the Updates screen.

Attachments (1)

39057.diff (2.0 KB) - added by afercia 9 months ago.

Download all attachments as: .zip

Change History (11)

@afercia
9 months ago

#1 @afercia
9 months ago

  • Keywords has-patch added; needs-patch removed

39057.diff should be good to go. Note: couldn't test wp.updates.showErrorInCredentialsForm(), actually I'm not sure how it is supposed to work :)

#2 @afercia
9 months ago

  • Milestone changed from Awaiting Review to 4.7.1

I'd propose to consider this for 4.7.1.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 months ago

#5 @dd32
8 months ago

In 39656:

Updates: Remove a stray " from a tag.

Props afercia.
See #39057.

#6 @dd32
8 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 39657:

Updates: Show the Authentication key settings after selecting the SSH transport in both the modal, and also on the plugin/theme updates screen.

Props afercia.
Fixes #39057 for trunk.

#7 @dd32
8 months ago

In 39658:

Updates: Show the Authentication key settings after selecting the SSH transport in both the modal, and also on the plugin/theme updates screen.

Props afercia.
Merges [39657] to the 4.7 branch.
Fixes #39057.

This ticket was mentioned in Slack in #core by dd32. View the logs.


8 months ago

#9 @dd32
8 months ago

In 39689:

Updates: Properly define $filesystemForm to handle error in modals.

Ammends [39657].
See #39057.

#10 @dd32
8 months ago

In 39690:

Updates: Properly define $filesystemForm to handle error in modals.

Amends [39657].
Merges [39689] to the 4.7 branch.
See #39057.

Note: See TracTickets for help on using tickets.