WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39060 closed enhancement (fixed)

Replace `is_super_admin()` check in `wp-admin/menu.php` with `update_core` capability check

Reported by: flixos90 Owned by: flixos90
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Role/Capability Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Description

This is part of the #37616 task. update_core is a suitable capability to use in wp-admin/menu.php.

Attachments (1)

39060.diff (459 bytes) - added by flixos90 3 years ago.

Download all attachments as: .zip

Change History (4)

@flixos90
3 years ago

#1 @flixos90
3 years ago

  • Keywords has-patch added
  • Owner set to flixos90
  • Status changed from new to assigned

#2 @jeremyfelt
3 years ago

39060.diff looks good, @flixos90. I think it's okay to add the {} to the if clause during commit since we're updating that area anyway.

It does seem like we could revisit this area and clean up the logic at the top of the file a bit more, but that shouldn't be part of this change.

#3 @flixos90
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39540:

Multisite: Replace is_super_admin() with update_core for update permissions.

Fixes #39060. See #37616.

Note: See TracTickets for help on using tickets.