WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#39064 closed enhancement (fixed)

Replace `is_super_admin()` checks with `manage_network` cap checks for admin bar permissions

Reported by: flixos90 Owned by: flixos90
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Role/Capability Keywords: has-patch
Focuses: multisite Cc:

Description

This is part of the #37616 task. There are 4 is_super_admin() checks in wp-includes/admin-bar.php that should be replaced with current_user_can( 'manage_network' ).

See https://core.trac.wordpress.org/ticket/37616#comment:23

Attachments (1)

admin-bar.diff (1.3 KB) - added by iaaxpage 5 months ago.
Replaced is_super_admin with current_user_can( 'manage_network' )

Download all attachments as: .zip

Change History (5)

@iaaxpage
5 months ago

Replaced is_super_admin with current_user_can( 'manage_network' )

#1 @iaaxpage
5 months ago

  • Keywords has-patch added

#2 @flixos90
5 months ago

  • Owner set to flixos90
  • Status changed from new to assigned

Thanks for the patch @iaaxpage - looking good! :)

#3 @iaaxpage
5 months ago

Thank you @flixos90. I wish I had the chance to meet you here in Philly, but I guess is a great excuse to go to WordCamp Europe next year. :D I saw there are many other tickets to be opened related to the task #37616. I'll be paying attention to help a little bit more.

#4 @flixos90
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39492:

Multisite: Replace is_super_admin() with manage_network for admin bar permissions.

Props iaaxpage.
Fixes #39064. See #37616.

Note: See TracTickets for help on using tickets.