WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Last modified 6 years ago

#39080 accepted enhancement

created unittest for is_serialized and is_serialized_string files and move tests into them

Reported by: pbearne Owned by: whyisjake
Priority: normal Milestone: Future Release
Component: General Version: 4.7
Severity: normal Keywords: has-patch has-unit-tests dev-feedback
Cc: Focuses:

Description

Move the tests from function.php to separate files and converted to dataprovider ans added move tests

Attachments (2)

is_serialized.patch​ (6.2 KB ) - added by pbearne 10 years ago.
combined patch
39080.diff​ (3.3 KB ) - added by whyisjake 6 years ago.

Download all attachments as: .zip

Change History (11)

@pbearne
10 years ago

combined patch

#1 @pbearne
10 years ago

  • Keywords has-patch has-unit-tests added

#2 @desrosj
8 years ago

  • Milestone Awaiting Review → Future Release
  • Owner set to desrosj
  • Status new → reviewing

#3 @desrosj
7 years ago

  • Owner desrosj removed

This ticket was mentioned in ​Slack in #core by noisysocks. ​View the logs.
6 years ago

#5 @whyisjake
6 years ago

  • Owner set to whyisjake
  • Status reviewing → accepted

@whyisjake
6 years ago

#6 @whyisjake
6 years ago

#39069 was marked as a duplicate.

#7 @whyisjake
6 years ago

  • Keywords dev-feedback added

👋can you give this updated patch a review @pbearne?

#8 @pbearne
6 years ago

@whyisjake patch looks good

#9 @whyisjake
6 years ago

/me just checked the patch and realized I didn't add the new test files... :/

Note: See TracTickets for help on using tickets.