WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 7 months ago

#39080 accepted enhancement

created unittest for is_serialized and is_serialized_string files and move tests into them

Reported by: pbearne Owned by: whyisjake
Milestone: Future Release Priority: normal
Severity: normal Version: 4.7
Component: General Keywords: has-patch has-unit-tests dev-feedback
Focuses: Cc:

Description

Move the tests from function.php to separate files and converted to dataprovider ans added move tests

Attachments (2)

is_serialized.patch (6.2 KB) - added by pbearne 4 years ago.
combined patch
39080.diff (3.3 KB) - added by whyisjake 8 months ago.

Download all attachments as: .zip

Change History (11)

@pbearne
4 years ago

combined patch

#1 @pbearne
4 years ago

  • Keywords has-patch has-unit-tests added

#2 @desrosj
21 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to desrosj
  • Status changed from new to reviewing

#3 @desrosj
10 months ago

  • Owner desrosj deleted

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


8 months ago

#5 @whyisjake
8 months ago

  • Owner set to whyisjake
  • Status changed from reviewing to accepted

@whyisjake
8 months ago

#6 @whyisjake
8 months ago

#39069 was marked as a duplicate.

#7 @whyisjake
8 months ago

  • Keywords dev-feedback added

👋can you give this updated patch a review @pbearne?

#8 @pbearne
8 months ago

@whyisjake patch looks good

#9 @whyisjake
7 months ago

/me just checked the patch and realized I didn't add the new test files... :/

Note: See TracTickets for help on using tickets.