WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#39085 closed defect (bug) (fixed)

RTL issue in the new Custom CSS

Reported by: ramiy's profile ramiy Owned by: westonruter's profile westonruter
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-screenshots has-patch commit dev-reviewed
Focuses: rtl Cc:

Description

The custom CSS textarea should always be LTR. Because it shows code, and code is in English (LTR language).

See the attached screenshot.

Attachments (3)

css-rtl.png​ (991.9 KB) - added by ramiy 8 years ago.
39085.0.diff​ (491 bytes) - added by westonruter 8 years ago.
39085.1.diff​ (544 bytes) - added by westonruter 8 years ago.
Use code class instead of dir=ltr

Download all attachments as: .zip

Change History (10)

@ramiy
8 years ago

#1 @ramiy
8 years ago

  • Keywords needs-patch has-screenshots added

I should say that there are several other places in WordPress admin that always use LTR direction, usually using the code class.

For example see: Settings > Writing > Update Services

@westonruter
8 years ago

#2 @westonruter
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to westonruter
  • Status changed from new to accepted

@westonruter
8 years ago

Use code class instead of dir=ltr

This ticket was mentioned in ​Slack in #core by westonruter. ​View the logs.
8 years ago

#4 @ocean90
8 years ago

  • Keywords commit added

39085.1.diff​ looks good.

#5 @westonruter
8 years ago

  • Keywords dev-reviewed added

#6 @westonruter
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 39499:

Customize: Ensure textarea for Custom CSS displays as code (in LTR) when an RTL language is active.

See #35395.
Fixes #39085.

#7 @westonruter
8 years ago

In 39500:

Customize: Ensure textarea for Custom CSS displays as code (in LTR) when an RTL language is active.

Merges [39499] onto 4.7 branch.
Fixes #39085 for 4.7.

Note: See TracTickets for help on using tickets.