Plugin handling Inconsistency as a consequence of ticket #3157

[z720]

I saw in ticket #3157 that constant PLUGINDIR was introduced instead of "wp-content/plugins", well but the job is half done...

When modified in wp-config.php PLUGINDIR works well for the admin part : the plugins get detected in the admin and can be activated. But they are totally ineffective in the frontend because they don't get loaded.

I found in wp-settings.php (in the trunk) at line 200

if ( get_option('active_plugins') ) {
	$current_plugins = get_option('active_plugins');
	if ( is_array($current_plugins) ) {
		foreach ($current_plugins as $plugin) {
			if ('' != $plugin && file_exists(ABSPATH . 'wp-content/plugins/' . $plugin))
				include_once(ABSPATH . 'wp-content/plugins/' . $plugin);
		}
	}
}

but it should be :

if ( get_option('active_plugins') ) {
	$current_plugins = get_option('active_plugins');
	if ( is_array($current_plugins) ) {
		foreach ($current_plugins as $plugin) {
			if ('' != $plugin && file_exists(ABSPATH . PLUGINDIR . $plugin))
				include_once(ABSPATH . PLUGINDIR . $plugin);
		}
	}
}

as PLUGINDIR is defined around line 95.

[markjaquith]

You'd need a slash between PLUGINDIR and $plugin

[ryan]

Somebody cook up a diff.

[Nazgul]

Patch based on given code snippet. I also included another reference in plugins.php.

[ryan]

(In [4972]) Use PLUGINDIR. Props z720 and Nazgul. fixes #3909