Opened 8 years ago
Closed 8 years ago
#39098 closed defect (bug) (fixed)
Customize: Clicking on child elements of preview links fails to abort navigation to non-previewable links
Reported by: | westonruter | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.7.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
In Twenty Seventeen, the social links nav menu has SVG elements as children of the nav menu item links. The handleLinkClick
function that handles delegated clicks on a
elements is currently checking if the event.target
lacks an href
attribute and if so, it short-circuits since it's not a link. But if the user clicks on a child element, then the event.target
is not actually the a
element but the clicked element. The logic for getting the link element needs to change as follows:
- link = $( event.target ); + link = $( event.target ).closest( 'a' );
Attachments (1)
Change History (11)
This ticket was mentioned in Slack in #core by helen. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
8 years ago
Note: See
TracTickets for help on using
tickets.
Patch applies cleanly and works as expected. Latest Chrome and Safari macOS.