WordPress.org

Make WordPress Core

Opened 10 months ago

Last modified 3 months ago

#39099 new defect (bug)

Customize: Defer triggering selective refresh for all settings until after synced

Reported by: westonruter Owned by:
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch needs-testing
Focuses: Cc:

Description

Selective refresh is triggered when a setting is added, changed, or removed. In the case of being added, there are scenarios where infinite full refresh can ensue if a partial has fallback refresh. This has been particularly evident for nav menus. While the infinite refreshes have largely been fixed for nav menus in #38612, there are still cases more generally where settings could be registered in the controls (admin) but not in the preview (pane). In the case of nav menus, this still causes a selective refresh to happen even at an initial page load.

This is essentially revisiting #37032.

Attachments (2)

39099.0.diff (1.7 KB) - added by westonruter 10 months ago.
39099.1.diff (2.1 KB) - added by westonruter 3 months ago.

Download all attachments as: .zip

Change History (11)

#1 @westonruter
10 months ago

  • Keywords has-patch added

Something that I still want to address is the scenario where a user may make a change to a postMessage-transport setting while a full refresh is happening. In that case, we *do* want there to be an initial selective refresh happening.

#2 @westonruter
10 months ago

Easiest way to reproduce this issue is to activate the Nav Menu Roles plugin and prevent a few menu items from being displayed when a user is logged in. When loading the customizer preview, the menu containing these excluded items will get initially selective-refreshed.

#3 @westonruter
10 months ago

  • Milestone changed from 4.7.1 to 4.8

#4 @celloexpressions
8 months ago

  • Version set to 4.7

+1, if we can eliminate the initial selective refresh for menus, even, this would be a big improvement. If the changes aren't too much more complex after addressing 1, I think it's worth getting this into the 4.7 branch.

#5 @westonruter
8 months ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core by flixos90. View the logs.


4 months ago

#7 @flixos90
4 months ago

  • Milestone changed from 4.8 to Future Release

@westonruter
3 months ago

#8 @westonruter
3 months ago

  • Milestone changed from Future Release to 4.9

#9 @westonruter
3 months ago

I noticed infinite refresh happening in Twenty Fifteen in 4.8 when deleting a menu assigned to a nav menu location.

Note: See TracTickets for help on using tickets.