Customize: Edit shortcuts do not work if page hasn't been saved and published

[davidakennedy]

This may not be possible to fix given the workflow, but it seemed like an issue.

In Twenty Seventeen:

1. Go to Customizer — Theme Options.
2. Make a new page (for a section).
3. Click on the edit icon for that new page/section.
4. Edit icon doesn’t do anything.
5. Click edit icon for existing page. That one works.

This makes some sense because the new page isn't saved and published yet, but it seems like the preview should still work with the page.

Reproduced by myself, @laurelfulford and @melchoyce.

[westonruter]

@sirbrillig can you assist with debugging this? It seems like the click handler is getting lost when the homepage section is refreshed.

[sirbrillig]

Looking into it. Definitely the click handler is not being added when a page section is refreshed. The following patch seems to fix the issue in my tests, which is a little odd. The patch just adds the click handler before the button is appended to the page. Since the reference should be maintained I don't know why that would work but my tests showed that the handler wasn't being removed; it looked like it was just not being added.

[sirbrillig]

Attach edit shortcut click handler before shortcut is added

[celloexpressions]

Confirmed that 39100.diff​ works. Odd, but very unlikely to cause other issues, so let's get it in.

[westonruter]

In 39581:

Customize: Prevent edit shortcut from losing event handler after selective refresh.

Props sirbrillig.
See #27403.
Fixes #39100.

[westonruter]

Reopening for 4.7.1.

[dd32]

In 39606:

Customize: Prevent edit shortcut from losing event handler after selective refresh.

Props sirbrillig.
Merges [39581] to the 4.7 branch.
See #27403.
Fixes #39100.