Customize: Shift-click on placeholder nav menu items fails to focus on the nav menu item control

[westonruter]

When you shift-click on a nav menu item in the customizer preview, the corresponding nav_menu_item control should be focused in the pane. However, currently when adding a new nav menu item in the customizer, shift-click is focusing on the nav menu location control as opposed to the nav menu item control.

[westonruter]

The fix is trivial. We just have to account for placeholder nav menu ids being negative in the regular expression: 39102.0.diff​.

Note that this would eventually be made irrelevant by #38072.

[westonruter]

This isn't a defect introduced in 4.7.

[westonruter]

In 39562:

Customize: Fix ability to shift-click on placeholder/pre-saved nav menu items in preview to focus on corresponding control.

Fixes #39102.

[westonruter]

While technically this issue existed before 4.7, I think actually it will be much more noticeable with starter content since shift-click on the menus won't open the nav menu item controls as a user would normally expect for nav menus that are already saved. So I'm milestoning this tiny fix for 4.7.1.

[celloexpressions]

Agreed that this should be in 4.7.1. It's a regression from previous behavior, closely tied to changes in 4.7, and the fix is trivial.

[dd32]

In 39572:

Customize: Fix ability to shift-click on placeholder/pre-saved nav menu items in preview to focus on corresponding control.

Props westonruter.
Merges [39562] to the 4.7 branch.
Fixes #39102.