WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 4 weeks ago

#39106 assigned enhancement

Make hierarchy level indicator text changeable [WP List]

Reported by: gk.loveweb Owned by:
Milestone: Future Release Priority: low
Severity: minor Version: 4.6.1
Component: Posts, Post Types Keywords: good-first-bug has-patch
Focuses: ui, administration Cc:

Description

In WP_Posts_List_Table class, dashes(—) used to indicate the hierarchy level of post item, which is not changeble by any filter, we can add a new filter to replace this string.

$pad = str_repeat( '— ', $this->current_level );

https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-posts-list-table.php#L918-L919

Source: http://wordpress.stackexchange.com/questions/248405/replace-dashes-before-title-in-page-list

Attachments (2)

39106.patch (1.1 KB) - added by rebasaurus 9 months ago.
Adding filter 'post_title_child_separator'
39106.diff (998 bytes) - added by mayankmajeji 4 weeks ago.
39106.diff

Download all attachments as: .zip

Change History (8)

#1 @gk.loveweb
4 years ago

  • Type changed from feature request to defect (bug)

#2 @valentinbora
9 months ago

  • Keywords good-first-bug needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to valentinbora
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Status changed from new to accepted
  • Type changed from defect (bug) to enhancement

#3 @valentinbora
9 months ago

  • Component changed from Administration to Posts, Post Types
  • Owner valentinbora deleted
  • Status changed from accepted to assigned

Thanks for the ticket @gkloveweb. I believe it makes sense to allow this to be tweakable so I've marked it accordingly.

It also seems like an easy to do change, so I've marked it as good-first-bug for new contributors to tackle.

@rebasaurus
9 months ago

Adding filter 'post_title_child_separator'

#4 @rebasaurus
9 months ago

  • Keywords has-patch added; needs-patch removed

#5 @seanchayes
2 months ago

I downloaded and tested this patch.

It worked as expected and I was easily able to change the separator used for the hierarchy post separator by adding the filter to my functions.php and trying out different combinations.

One code change I would suggest is to rename name the variable used from $pad to $separator - as I believe this would more closely match the name of the suggested filter naming.

@mayankmajeji
4 weeks ago

39106.diff

#6 @mayankmajeji
4 weeks ago

I completely agree with @seanchayes and changed $pad to $separator as it makes more sense and semantically correct. I also cross-checked for the conflicts and find zero conflicts.

Note: See TracTickets for help on using tickets.