WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39107 closed defect (bug) (invalid)

Theme starter content: typo in homepage section post_content

Reported by: dimadin Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Themes Keywords: close
Focuses: Cc:

Description

I think that this should be singular.

Attachments (1)

39107.diff (798 bytes) - added by dimadin 3 years ago.

Download all attachments as: .zip

Change History (5)

@dimadin
3 years ago

#1 @ocean90
3 years ago

  • Keywords close added

Plural looks fine to me, a page can have more than one homepage sections/panels. Twenty Seventeen supports four by default: https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyseventeen/functions.php?rev=39373&marks=162-165#L161

#2 @dimadin
3 years ago

But those are other sections/panels that each has its own post and post_content, and there can be only one "homepage section"?

In any case, the rest of that sentence sounds like it talks about one section, shouldn't that part be changed? Maybe it's just because I'm not a native speaker, but that sentence doesn't sound right to me.

#3 @Presskopp
3 years ago

Better?
This is an example of a homepage section. Homepage sections can include any page besides the homepage itself, including the page that shows your latest blog posts.

If it should be plural or not seems academic to me.

#4 @helen
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Not a typo; as @ocean90 noted, there are multiple homepage sections in Twenty Seventeen. Homepage sections are set to individual pages, they do not "include" them - using include makes it sound like you can set a homepage section to include multiple pages.

Fine with rewriting content over time, but in the case of this ticket, it is not a typo, and we are in code freeze and hours away from release for 4.7, which means not altering strings unless there is a serious problem.

Note: See TracTickets for help on using tickets.