Twenty Seventeen: Display & improve translator comment for Libre Franklin font on/off

[petya]

The translator comment for the string that turns Twenty Seventeen's Libre Franklin font on or off (https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyseventeen/functions.php#L230) is not visible in translate.wordpress.org

Screen: ​https://www.dropbox.com/s/sv708wl3i5evh6i/Screenshot%202016-12-06%2014.06.22.png?dl=0
Link: ​https://translate.wordpress.org/projects/wp-themes/twentyseventeen/bg/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=3565021&filters%5Btranslation_id%5D=46251052

The comment is in the code reference and says:

"Translators: If there are characters in your language that are not supported by Libre Franklin, translate this to 'off'. Do not translate into your own language."

Even if the comment was visible, it would be of next to no help to translators without a reference to the link or further explanation. Translators are often neither designers nor developers. My suggestion here is to add a further line explaining which scripts are supported by the font or if they are two many either which are not or a link for translators to check whether their script is supported.

[swissspidy]

makepot.php doesn't recognize /** apparently. 39116.diff​ resorts to using /* for the multiline comment (correct anyway as per coding standards)

[netweb]

See #30603 for a historical explanation of this.

[SergeyBiryukov]

Replying to swissspidy:

makepot.php doesn't recognize /** apparently. 39116.diff​ resorts to using /* for the multiline comment (correct anyway as per coding standards)

Yep. We could probably fix StringExtractor to recognize that (see #30972 for a previous fix to improve support for multi-line comments), but I think we should just go with 39116.diff​, since it should be a regular comment, not a DocBlock.

[SergeyBiryukov]

In 39894:

Twenty Seventeen: Remove extra asterisk from a translator comment so the comment could be parsed correctly.

Props swissspidy.
See #39116.

[SergeyBiryukov]

Replying to petya:

My suggestion here is to add a further line explaining which scripts are supported by the font or if they are two many either which are not or a link for translators to check whether their script is supported.

That comment is consistent with the comments from previous bundled themes:

• ​Twenty Sixteen
• Twenty Fifteen​
• Twenty Fourteen​
• Twenty Thirteen​
• Twenty Twelve​

The original comment was added for Twenty Twelve in #21751, see [22020] and [22049].

If the suggestion is to change it, I think it should be done for all themes.

[davidakennedy]

@petya Would adding a link to the Google Font documentation for the theme's fonts help in this case? Example: ​https://fonts.google.com/specimen/Merriweather

[SergeyBiryukov]

Closing as fixed for 4.8 in [39894], let's open a new ticket for any further enhancements.