WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 9 months ago

Last modified 9 months ago

#39118 closed enhancement (fixed)

Verify change of single site admin email address before it changes

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch commit
Focuses: administration Cc:

Description

On a multisite installation it's not possible to change the Email Address setting on a site without first clicking the confirmation link that gets emailed to the new address.

This same behaviour should be implemented on regular single site installations to avoid the address being inadvertently set to an incorrect address.

Attachments (2)

39118.diff (10.9 KB) - added by MatheusGimenez 17 months ago.
Added verify email on change site admin email in single site installations
39118.2.diff (17.0 KB) - added by johnbillion 10 months ago.

Download all attachments as: .zip

Change History (15)

@MatheusGimenez
17 months ago

Added verify email on change site admin email in single site installations

#1 @MatheusGimenez
16 months ago

  • Keywords needs-patch removed

#2 @thomaswm
16 months ago

  • Keywords has-patch needs-testing added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


13 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


13 months ago

#6 @jbpaul17
13 months ago

  • Milestone changed from 4.8 to 4.8.1

Punting to 4.8.1 per today's bug scrub.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


11 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


10 months ago

#9 @jbpaul17
10 months ago

  • Milestone changed from 4.8.1 to 4.9

Per today's bug scrub, we'll punt this as the focus for 4.8.1 is regressions only.

#10 @johnbillion
10 months ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

#11 @johnbillion
10 months ago

  • Keywords commit added; needs-testing removed

39118.2.diff is a refresh plus some fixes that take into account the option whitelisting. I'm happy with this and I think it's good to go.

#12 @johnbillion
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41254:

Options, Meta APIs: Require a confirmation link in an email to be clicked when an admin attempts to change the site admin email address.

This adds this previously Multisite-only functionality to single site installations too. This change prevents accidental or erroneous email address changes from potentially locking users out of their site.

Props MatheusGimenez, johnbillion

Fixes #39118

#13 @johnbillion
9 months ago

In 41255:

Options, Meta APIs: Update the multisite unit tests after [41254], [41164], and [41163].

This moves some more previously Multisite-only tests into the main test suite, and makes small adjustments to their assertions.

See #39118, #16470, #39117

Note: See TracTickets for help on using tickets.