Make WordPress Core

Opened 8 years ago

Closed 2 weeks ago

#39121 closed defect (bug) (wontfix)

Twenty Twelve: Tagcloud has tags hyphenated over line breaks

Reported by: xuhdev's profile xuhdev Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch close
Focuses: Cc:

Description

I'm using theme TwentyTwelve and I observed that tagcloud has tags hyphenated over line breaks. I suggest to fix it by adding the following to the stylesheet:

.tagcloud {
  -webkit-hyphens: none;
  -moz-hyphens: none;
  -ms-hyphens: none;
  hyphens: none;
}

Maybe this can even be put somewhere that applies to all themes...

Attachments (6)

Screen Shot 2019-01-16 at 2.44.25 PM.png (44.9 KB) - added by laurelfulford 5 years ago.
Twenty Twelve - tag cloud with long tag hyphenated
39121.diff (535 bytes) - added by ianbelanger 5 years ago.
Removes hyphenation and changes word-wrap: break-word; to word-break: break-all; for complete browser support
39121-chrome-after-patch.PNG (18.5 KB) - added by ianbelanger 5 years ago.
Chrome after patch
39121-firefox-after-patch.PNG (19.3 KB) - added by ianbelanger 5 years ago.
Firefox after patch
39121-ie11-after-patch.PNG (14.5 KB) - added by ianbelanger 5 years ago.
IE11 after patch
SCR-20240625-iwzn.png (166.6 KB) - added by karmatosed 3 weeks ago.

Download all attachments as: .zip

Change History (12)

#1 @swissspidy
8 years ago

  • Component changed from Themes to Bundled Theme
  • Focuses ui removed
  • Version 4.6.1 deleted

#2 @SergeyBiryukov
8 years ago

  • Summary changed from Tagcloud has tags hyphenated over line breaks in TwentyTwelve to Twenty Twelve: Tagcloud has tags hyphenated over line breaks

@laurelfulford
5 years ago

Twenty Twelve - tag cloud with long tag hyphenated

#3 @laurelfulford
5 years ago

  • Keywords needs-patch has-screenshots added
  • Milestone changed from Awaiting Review to Future Release

Thanks for reporting this issue, @xuhdev!

I can recreate this issue -- oddly, the tag "this is a tag that is a long sentence not a word" gets hyphenated, breaking 'sentence' over two lines, but the tag "Loooooooooooooooooooong" just runs out of the content space (instead of breaking over two lines).

The culprit looks to be this CSS:

.widget-area .widget {
    -moz-hyphens: auto;
    hyphens: auto;
    word-wrap: break-word;
}

@ianbelanger
5 years ago

Removes hyphenation and changes word-wrap: break-word; to word-break: break-all; for complete browser support

@ianbelanger
5 years ago

Chrome after patch

@ianbelanger
5 years ago

Firefox after patch

@ianbelanger
5 years ago

IE11 after patch

#4 @ianbelanger
5 years ago

  • Keywords has-patch added; needs-patch removed

@laurelfulford could you check my patch in various browsers on a Mac? It works for all in Windows. Also, not sure if this is the approach we want to take. Would love to get your opinion on it. I like it because it allows for consistency across all browsers. I'm going to check this issue against the other Twenty Themes.

#5 @karmatosed
3 weeks ago

  • Keywords close added

I have just been testing this and it doesn't work for longer words on mac, which I think is where right now this issue is the most noticeable. I will share an image of what on Safari this looks like with patch today. I think we have to face the reality this has sat for a while in the theme. If we want to fix I would suggest we resolve across all browsers, if we don't we just leave it.

My current recommendation would be to close this issue as time has passed and it is a very edge case of an edge case. That said I am happy for discussion so leaving it with a recommendation to close for discussions.

#6 @karmatosed
2 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to follow through and close this now, thank you everyone.

Note: See TracTickets for help on using tickets.