WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #39122, comment 5


Ignore:
Timestamp:
08/12/2018 09:34:16 PM (6 years ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #39122, comment 5

    initial v1  
    55- Adds {{{@ticket}}} annotations.
    66- Use {{{asserSame}}} instead of {{{assertEquals}}}, as {{{null}}}, {{{false}}} and {{{''}}} are equal under {{{assertEquals}}}.
    7 - Use {{{assertFalse}}} instead of      {{{assertEquals( false, ... ) );}}}
    8 - Additional note: Instead of {{{$this->assertEquals( false, isset( $meta['test_cat_meta'] ) );}}}, one could consider {{{assertArrayNotHasKey}}}, but we note that it also returns {{{true}}} for {{{null}}} values. But I didn't change it in the patch to use {{{assertArrayNotHasKey}}}.
     7- Use {{{assertFalse}}} instead of      {{{assertEquals( false, ... )}}}
     8
     9Additional note: Instead of {{{$this->assertEquals( false, isset( $meta['test_cat_meta'] ) );}}}, one could consider {{{assertArrayNotHasKey}}}, but we note that it also returns {{{true}}} for {{{null}}} values. But I didn't change it in the patch to use {{{assertArrayNotHasKey}}}.
    910