WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#39137 closed enhancement (fixed)

Commented Codes Found on css files

Reported by: kafleg Owned by: afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

Commented CSS codes found on wp-includes/css/admin-bar-rtl.css on line 801 to 808.

/*	These rules break dropdown tappability on Chrome/Android.
		-webkit-transform: translate3d(0, 0, 0);
		-webkit-backface-visibility: hidden;
		-webkit-transition: 0;
		transform: translate3d(0, 0, 0);
		backface-visibility: hidden;
		transition: 0;
*/ 

I think, commented code is not necessary on files.

Regards

Attachments (1)

39137.patch (592 bytes) - added by ketuchetan 5 months ago.
Removed the commented code from the admin-bar-rtl.css file

Download all attachments as: .zip

Change History (4)

#1 @ketuchetan
5 months ago

  • Keywords has-patch added

Removed the Commented CSS from the admin-bar.css file.

@ketuchetan
5 months ago

Removed the commented code from the admin-bar-rtl.css file

#2 @afercia
5 months ago

  • Component changed from General to Toolbar
  • Milestone changed from Awaiting Review to 4.8
  • Owner set to afercia
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement
  • Version 4.7 deleted

Thanks @kafleg and @ketuchetan, seems it's commented out since 3 years, I think it can be safely removed :) Worth noting the CSS files get minified and comments removed so the source files are used only in debug mode.
Introduced in [26770], for some background see the related ticket #25972.

#3 @afercia
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39533:

Toolbar: remove some unnecessary CSS lines.

They were commented out in admin-bar.css since 3 years, see [26770].

Props kafleg, ketuchetan.

Fixes #39137.

Note: See TracTickets for help on using tickets.