Correct concatenated dynamic hooks

[keesiemeijer]

Cleaning up concatenated dynamic hooks as per the ​coding-standards

Related: #38462

[keesiemeijer]

Use interpolation for naming of dynamic hooks

[MaximeCulea]

Hi @keesiemeijer,
It's a good idea, but that means cleaning a lot of current hooks :confused:
Moreover, I've heard that when formatting and/or coding standards are in, rather than applying to all curent application it's preferable to only apply on new tickets.

[keesiemeijer]

I understand, but the documentation in ​the code reference relies on the hook names to be correct. For a fun example look here: ​https://developer.wordpress.org/reference/hooks/handle_bulk_actions-get_current_screen-id/

Should I create separate tickets for all of them?

[MaximeCulea]

@keesiemeijer no need, but better wait for a core-team point of view ;)

[johnbillion]

Thanks for the patch, @keesiemeijer.

These dynamic hook names are indeed incorrect. Here's an example of where the hook name gets messed up on the code reference:

​https://developer.wordpress.org/reference/hooks/handle_bulk_actions-get_current_screen-id/

[ocean90]

#39193 was marked as a duplicate.

[johnbillion]

In 39600:

General: Use interpolation instead of concatenation for all dynamic hook names.

This fixes the rendering of the hook names on developer.wordpress.org.

Props keesiemeijer
Fixes #39148