Twenty Seventeen: phpcs errors and warnings
|Reported by:||dingo_bastard||Owned by:||davidakennedy|
Since we are aiming towards automation of the theme review, as described in this blog post I wanted to check what's the status with the newly Twenty Seventeen theme.
I used the WordPress coding standard (which also includes the VIP standard sniffs which we can ignore), and ignored the *.js and *.css files (errors there were mostly based about spacing and inline comments, which the phpcs pulled from php rules).
I'm attaching the log file with the errors. Some can be easily fixed by running phpcbf, but some should be taken care of manually - for instance in the content-video.php file located in the \template-parts\post folder on line 67 there is
which should be escaped (I added esc_html() and the test videos provided in the theme unit test worked).
Hope this helps :)
Change History (11)
5 months ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 4.8
- Type changed from enhancement to defect (bug)